You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "SBIN2010 (via GitHub)" <gi...@apache.org> on 2025/08/25 19:55:04 UTC
[PR] feat(waterfall): add changes label series and grouping customize settings [superset]
SBIN2010 opened a new pull request, #34847:
URL: https://github.com/apache/superset/pull/34847
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
This PR Waterfall chart improvement #27856
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
1) Added tooltips for series color settings
2) Series settings, X-axis, Y-axis are separated into separate groups
3) Added a change in the lable of the series
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
<img width="337" height="374" alt="Снимок экрана от 2025-08-25 22-52-45" src="https://github.com/user-attachments/assets/fa576148-56fb-4bb2-8162-c741f450c3d2" />
<img width="2201" height="1252" alt="Снимок экрана от 2025-08-25 22-54-28" src="https://github.com/user-attachments/assets/97703a66-7600-47b7-a179-4a296e96fdbe" />
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #34847:
URL: https://github.com/apache/superset/pull/34847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3294009477
> Ah, thanks for the feedback - I didn't enable a legend so I missed those spots. I updated my previous comment, does the updated text capture it more accurately now?
Yes, now it looks good, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3300443162
@michael-s-molina @stephenLYZ
Do you have any further comments on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3265849910
thanks @SBIN2010! I am spinning up a test env so that it's easier to see the changes.
I think visually the changes make a lot of sense. If I could ask you to change one thing that would help a lot - we are moving towards sentence case labels, and some slip - I can see that one of the checkboxes "Show Value" is still title case. Can you make it sentence too?
In terms of changes of the labels in x/y axis sections I'll wait for @yousoph to take a look to make sure, that it's all correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3221794405
Thank you for implementing the request at #27856! @kasiazjc I know you have given great design feedback on other PRs, do you have any feedback on the UI for these new controls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3267283694
hi @SBIN2010 ! Thanks for these additional customizations!
A few suggestions on wording:
The section header: Series setting -> Series settings
Above the color labels, add the word color: Increase -> Increase color, Decrease -> Decrease color, Total -> Total color
Tooltip for colors:
Choose the color for series increase -> Select the color used for values that indicate an increase in the chart
Choose the color for series decrease -> Select the color used for values that indicate an increase in the chart
Choose the color for series total -> Select the color used for values that represent total bars in the chart
Tooltip for Labels:
Change the increase label to text -> Customize the label displayed for increasing values in the chart tooltips
Change the decrease label to text -> Customize the label displayed for decreasing values in the chart tooltips
Change the total label to text -> Customize the label displayed for total values in the chart tooltips
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3267478144
Hi @yousoph! Thanks for the suggestions!
Perhaps such a hint for labels will be misleading? The scope is not only in the hint, but also in the legend, and for the total, in the labels on the X axis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3265856019
@kasiazjc Ephemeral environment spinning up at http://54.188.60.228:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3259789061
@yousoph @kasiazjc could you please give some feedback on the design of these new controls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3293957401
Ah, thanks for the feedback - I didn't enable a legend so I missed those spots. I updated my previous comment, does the updated text capture it more accurately now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(waterfall): add changes label series and grouping customize settings [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34847:
URL: https://github.com/apache/superset/pull/34847#issuecomment-3265822840
⚠️ **DEPRECATED WORKFLOW** ⚠️
@kasiazjc This workflow is deprecated! Please use the new **Superset Showtime** system instead:
- Replace "testenv-up" label with "🎪 trigger-start"
- Better reliability and easier management
- See https://github.com/mistercrunch/superset-showtime for details
Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/17548971570). Action: **up**. More information on [how to use or configure ephemeral environments](https://superset.apache.org/docs/contributing/howtos/#github-ephemeral-environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org