You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/13 19:50:00 UTC

[jira] [Commented] (MINIFICPP-346) Add bustache to bootstrap

    [ https://issues.apache.org/jira/browse/MINIFICPP-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289787#comment-16289787 ] 

ASF GitHub Bot commented on MINIFICPP-346:
------------------------------------------

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/220

    MINIFICPP-346: Add automated detection that we cannot build bustache …

    …via bootstrap and eliminate it from travis
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-346

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #220
    
----
commit 5dd2c6d83cce45c4d2fa0c900fdd582e28849635
Author: Marc Parisi <ph...@apache.org>
Date:   2017-12-13T19:37:57Z

    MINIFICPP-346: Add automated detection that we cannot build bustache via bootstrap and eliminate it from travis

----


> Add bustache to bootstrap
> -------------------------
>
>                 Key: MINIFICPP-346
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-346
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: marco polo
>            Assignee: marco polo
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)