You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2026/05/22 00:44:02 UTC
[PR] [AMORO #4232] Improve AmsThriftUrl parsing and validation. [amoro]
slfan1989 opened a new pull request, #4233:
URL: https://github.com/apache/amoro/pull/4233
## Why are the changes needed?
Close #4232.
`AmsThriftUrl` is used to parse AMS thrift and ZooKeeper URLs. The previous thrift URL parsing lowercased the whole URL before parsing, which could unexpectedly change case-sensitive parts such as catalog names or query values.
This patch improves URL parsing robustness by preserving the original URL case and adding clearer validation for invalid thrift URLs.
## Brief change log
- Avoid lowercasing the whole thrift URL during parsing.
- Keep URL scheme matching case-insensitive.
- Preserve host, catalog name, and query value case.
- Add explicit validation for thrift URL:
- unsupported scheme
- missing host
- missing port
- Extract shared `socketTimeout` query parsing logic.
- Make `socketTimeout` parameter name case-insensitive.
- Add `TestAmsThriftUrl` unit tests.
## How was this patch tested?
- [X] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [X] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO #4232] Improve AmsThriftUrl parsing and validation. [amoro]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4233:
URL: https://github.com/apache/amoro/pull/4233#issuecomment-4763796283
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org