You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "spyhunter99 (via GitHub)" <gi...@apache.org> on 2025/10/22 21:08:31 UTC
[PR] JSPWIKI-1189 fixes the describe issues with unsaved page edits [jspwiki]
spyhunter99 opened a new pull request, #403:
URL: https://github.com/apache/jspwiki/pull/403
i.e. it removes the previous modal configuration (pink overlay setup) with a newer html5 based dialog.
i've checked the code and it looks like the only other thing that calls this javascript api is related to jsonrpc. I'm not sure if that's still used or not.
Submitting for feedback
Example presentation is below
<img width="1905" height="811" alt="image" src="https://github.com/user-attachments/assets/3507ab3d-56c1-4e2b-9a52-18dbf464aadc" />
and in dark mode
<img width="1905" height="827" alt="image" src="https://github.com/user-attachments/assets/cc6363ba-a054-4931-8528-97b6b2a5f109" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1189 fixes the described issue with unsaved page edits [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #403:
URL: https://github.com/apache/jspwiki/pull/403#issuecomment-3591832102
There's still some funky behavior with the browser forward/back buttons. it seems as if the dialog html element affects the history stack so when navigating back and forth can cause the dialog to popup multiple times. From the docs, it might be a jspwiki specific thing. not entirely sure at the moment.
the real long term fix is to do a complete overhaul of the ui.. but that's a lot of work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1189 fixes the described issue with unsaved page edits [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 closed pull request #403: JSPWIKI-1189 fixes the described issue with unsaved page edits
URL: https://github.com/apache/jspwiki/pull/403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1189 fixes the describe issues with unsaved page edits [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #403:
URL: https://github.com/apache/jspwiki/pull/403#issuecomment-3439571458
so this builds ok on by end with JDK17. CI says this is the issue: <html><body>
GroupPermissionTest.testImpliesMember:115 expected: <true> but was: false
odd since this doesn't change anything related to permissions structures. i'm guessing there some instability in that test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1189 fixes the described issue with unsaved page edits [jspwiki]
Posted by "juanpablo-santos (via GitHub)" <gi...@apache.org>.
juanpablo-santos commented on PR #403:
URL: https://github.com/apache/jspwiki/pull/403#issuecomment-3538589771
Hi, this LGTM, but not sure the implications on the json-rpc layer, we do use it to allow our js files access JSPWiki internals. @brushed yours would be a much better opinion on this, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1189 fixes the described issue with unsaved page edits [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #403:
URL: https://github.com/apache/jspwiki/pull/403#issuecomment-3582664363
retesting this, looks like the logout button used this same junk of modal magic, which is now broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1189 fixes the described issue with unsaved page edits [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #403:
URL: https://github.com/apache/jspwiki/pull/403#issuecomment-3651310864
closing this one, i have another branch with a simpler solution in the works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org