[GitHub] [cassandra] maedhroz commented on a diff in pull request #1949: CASSANDRA-16491 track and handle errors during nodetool bootstrap resume properly

[GitBox <gi...@apache.org>]

maedhroz commented on code in PR #1949:
URL: https://github.com/apache/cassandra/pull/1949#discussion_r1005181203


##########
src/java/org/apache/cassandra/tools/BootstrapMonitor.java:
##########
@@ -34,6 +34,7 @@ public class BootstrapMonitor extends JMXNotificationProgressListener
     private final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss,SSS");
     private final PrintStream out;
     private final Condition condition = newOneTimeCondition();
+    private Exception error;

Review Comment:
   I think this is going to need to be `volatile`, as it's written by one thread and accessed by another.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org