You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Madan US <ma...@collab.net> on 2005/03/14 18:29:58 UTC
[PATCH] Issue #2214: poor error message when intermediate dir missing in copy
[[[
Fixed Issue #2214: poor error message when intermediate dir missing
in copy.
* subversion/tests/clients/cmdline/copy_tests.py
(url_2_non_existent_url_path): Added to test
'svn cp' into a directory path in which
* subversion/libsvn_repos/commit.c
(open_directory): Removed call of
out_of_date() and added apropriate error
message.
]]]
Re: [PATCH] Issue #2214: poor error message when intermediate dir missing in copy
Posted by "C. Michael Pilato" <cm...@collab.net>.
Madan U Sreenivasan <ma...@collab.net> writes:
> On Tue, 2005-03-15 at 22:57, Julian Foad wrote:
> > Madan US wrote:
> [...]
> > Please could you try to make your attachments have a text MIME type, rather
> > than "application/octet-stream", so that we can see them more easily?
> I'm able to view the attachments inline :-?
> Am not sure how to change the mime type(evolution client). Could you pl.
> help me out.
Try naming the patchfiles with a .txt extension?
In Evolution 2, you can view the properties of attachments added to
the mail-in-progress to verify their proposed MIME-type. .txt gets me
"text/plain". .patch gets me "text/x-patch". Dunno where the
"application/octet-stream" is coming from...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Issue #2214: poor error message when intermediate dir
missing in copy
Posted by Julian Foad <ju...@btopenworld.com>.
Madan U Sreenivasan wrote:
> On Tue, 2005-03-15 at 22:57, Julian Foad wrote:
>>Please could you try to make your attachments have a text MIME type, rather
>>than "application/octet-stream", so that we can see them more easily?
>
> I'm able to view the attachments inline :-?
I can't see them in Mozilla - I have to save them first.
> Am not sure how to change the mime type(evolution client). Could you pl.
> help me out.
Sorry, I don't know Evolution at all.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Issue #2214: poor error message when intermediate dir
missing in copy
Posted by Madan U Sreenivasan <ma...@collab.net>.
On Tue, 2005-03-15 at 22:57, Julian Foad wrote:
> Madan US wrote:
[...]
> Please could you try to make your attachments have a text MIME type, rather
> than "application/octet-stream", so that we can see them more easily?
I'm able to view the attachments inline :-?
Am not sure how to change the mime type(evolution client). Could you pl.
help me out.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Issue #2214: poor error message when intermediate dir
missing in copy
Posted by Julian Foad <ju...@btopenworld.com>.
Madan US wrote:
> [[[
> Fixed Issue #2214: poor error message when intermediate dir missing
> in copy.
>
> * subversion/tests/clients/cmdline/copy_tests.py
> (url_2_non_existent_url_path): Added to test
> 'svn cp' into a directory path in which
Unfinished sentence.
>
> * subversion/libsvn_repos/commit.c
> (open_directory): Removed call of
> out_of_date() and added apropriate error
> message.
> ]]]
Please could you try to make your attachments have a text MIME type, rather
than "application/octet-stream", so that we can see them more easily?
> Index: subversion/libsvn_repos/commit.c
> ===================================================================
> --- subversion/libsvn_repos/commit.c (revision 13397)
> +++ subversion/libsvn_repos/commit.c (working copy)
> @@ -300,7 +300,9 @@
> else return an out-of-dateness error. */
> SVN_ERR (svn_fs_check_path (&kind, eb->txn_root, full_path, pool));
> if (kind == svn_node_none)
> - return out_of_date (full_path, eb->txn_name);
> + return svn_error_createf (SVN_ERR_FS_NOT_DIRECTORY, NULL,
> + _("Path '%s' not present"),
> + path);
This code doesn't agree with the comment just above it. (It didn't before, but
that's no excuse.)
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org