You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/06/07 22:47:15 UTC

[GitHub] [zookeeper] li4wang commented on pull request #1698: ZOOKEEPER-4289: Reduce the performance impact of Prometheus metrics

li4wang commented on pull request #1698:
URL: https://github.com/apache/zookeeper/pull/1698#issuecomment-856311027


   Thanks a lot for reviewing it, @anmolnar .
   
   No, I think we would want to enable this in normal cases. I added the support for num_works to 0 to provide the flexibility /possibility to switch between sync vs async for the cases of
   
   1.  people want to run benchmark comparison tests with and without the fix
   2. people really have limited number of threads they can use for the system
   
   I can definitely remove the support if we don't need to support the above the cases. 
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org