You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by interma <gi...@git.apache.org> on 2017/08/29 07:54:40 UTC
[GitHub] incubator-hawq pull request #1282: HAWQ-1520. gpcheckhdfs should skip hdfs t...
GitHub user interma opened a pull request:
https://github.com/apache/incubator-hawq/pull/1282
HAWQ-1520. gpcheckhdfs should skip hdfs trash directory
When enable **hdfs trash** feature, there is a *Trash* directory under the encryption zone.
So gpcheckhdfs should still consider the hawq directory contains *Trash* directory as an empty directory.
more details in JIRA:
https://issues.apache.org/jira/browse/HAWQ-1520
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/interma/interma-hawq hawq-1520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1282
----
commit c1e5a4f95f97a63d643d10cf081349f473d29170
Author: interma <in...@outlook.com>
Date: 2017-08-29T07:46:24Z
HAWQ-1520. gpcheckhdfs should skip hdfs trash directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1282: HAWQ-1520. gpcheckhdfs should skip hdfs trash di...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1282
@radarwave @linwen @wcl14 help to review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1282: HAWQ-1520. gpcheckhdfs should skip hdfs t...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1282#discussion_r136245201
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -271,6 +273,21 @@ int testHdfsConnect(hdfsFS * fsptr, const char * host, int iPort,
return 0;
}
+/*
+ * check path is a trash directory
+ * path, e.g: /hawq_default/.Trash
+ */
+static int is_trash_directory(const char *path) {
--- End diff --
thanks, I will fix it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1282: HAWQ-1520. gpcheckhdfs should skip hdfs t...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1282#discussion_r136239626
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -271,6 +273,21 @@ int testHdfsConnect(hdfsFS * fsptr, const char * host, int iPort,
return 0;
}
+/*
+ * check path is a trash directory
+ * path, e.g: /hawq_default/.Trash
+ */
+static int is_trash_directory(const char *path) {
--- End diff --
I suggest the name of this function uses "isTrashDirectory" instead of current one, since the other functions name follow this style: testFooBar, testXxxYyy, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1282: HAWQ-1520. gpcheckhdfs should skip hdfs trash di...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1282
merged
---
[GitHub] incubator-hawq pull request #1282: HAWQ-1520. gpcheckhdfs should skip hdfs t...
Posted by interma <gi...@git.apache.org>.
Github user interma closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1282
---
[GitHub] incubator-hawq issue #1282: HAWQ-1520. gpcheckhdfs should skip hdfs trash di...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1282
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---