You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by pn...@apache.org on 2019/05/07 07:44:28 UTC

[flink] 01/07: [hotfix][kafka,test] Improve error message

This is an automated email from the ASF dual-hosted git repository.

pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit a9e5395e5bd4980e1451b84ae7116746b81ff109
Author: Piotr Nowojski <pi...@gmail.com>
AuthorDate: Thu Feb 7 13:35:10 2019 +0100

    [hotfix][kafka,test] Improve error message
    
    If expected or actual elements are small enough, print them directly instead of printing the elements count.
---
 .../flink/streaming/connectors/kafka/KafkaTestBase.java       | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
index d23523f..712c0a8 100644
--- a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
+++ b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
@@ -274,6 +274,15 @@ public abstract class KafkaTestBase extends TestLogger {
 			}
 		}
 
-		fail(String.format("Expected number of elements: <%s>, but was: <%s>", expectedElements.size(), actualElements.size()));
+		fail(String.format("Expected %s, but was: %s", formatElements(expectedElements), formatElements(actualElements)));
+	}
+
+	private String formatElements(List<Integer> elements) {
+		if (elements.size() > 50) {
+			return String.format("number of elements: <%s>", elements.size());
+		}
+		else {
+			return String.format("elements: <%s>", elements);
+		}
 	}
 }