You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/28 13:14:06 UTC
[GitHub] [incubator-inlong] kipshi opened a new pull request #2792: [INlONG-2791] Optimize Inlong manager client apis
kipshi opened a new pull request #2792:
URL: https://github.com/apache/incubator-inlong/pull/2792
### Title Name: [INlONG-2791] Optimize Inlong manager client apis
where *XYZ* should be replaced by the actual issue number.
Fixes #2791
### Motivation
optimize methods in client
### Modifications
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #2792: [INlONG-2791][Manager] Optimize manager client APIs
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2792:
URL: https://github.com/apache/incubator-inlong/pull/2792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong edited a comment on pull request #2792: [INlONG-2791][Manager] Optimize manager client APIs
Posted by GitBox <gi...@apache.org>.
gong edited a comment on pull request #2792:
URL: https://github.com/apache/incubator-inlong/pull/2792#issuecomment-1054989353
only modify `SinkPageRequest` and `SourcePageRequest` will cause some problem.
StreamSinkServiceImpl
```java
public PageInfo<? extends SinkListResponse> listByCondition(SinkPageRequest request) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("begin to list sink page by " + request);
}
Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
String sinkType = request.getSinkType();
Preconditions.checkNotNull(sinkType, Constant.SINK_TYPE_IS_EMPTY);
```
StreamSourceServiceImpl
```java
public PageInfo<? extends SourceListResponse> listByCondition(SourcePageRequest request) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("begin to list source page by " + request);
}
Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
String sourceType = request.getSourceType();
Preconditions.checkNotNull(sourceType, Constant.SOURCE_TYPE_IS_EMPTY);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong edited a comment on pull request #2792: [INlONG-2791][Manager] Optimize manager client APIs
Posted by GitBox <gi...@apache.org>.
gong edited a comment on pull request #2792:
URL: https://github.com/apache/incubator-inlong/pull/2792#issuecomment-1054989353
only modify `SinkPageRequest` and `SourcePageRequest` will cause some problem.
StreamSinkServiceImpl
```java
public PageInfo<? extends SinkListResponse> listByCondition(SinkPageRequest request) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("begin to list sink page by " + request);
}
Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
String sinkType = request.getSinkType();
Preconditions.checkNotNull(sinkType, Constant.SINK_TYPE_IS_EMPTY);
```
StreamSourceServiceImpl
```java
public PageInfo<? extends SourceListResponse> listByCondition(SourcePageRequest request) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("begin to list source page by " + request);
}
Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
String sourceType = request.getSourceType();
Preconditions.checkNotNull(sourceType, Constant.SOURCE_TYPE_IS_EMPTY);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong commented on pull request #2792: [INlONG-2791][Manager] Optimize manager client APIs
Posted by GitBox <gi...@apache.org>.
gong commented on pull request #2792:
URL: https://github.com/apache/incubator-inlong/pull/2792#issuecomment-1054989353
only modify `SinkPageRequest` and `SourcePageRequest` will cause some problem.
StreamSinkServiceImpl
` public PageInfo<? extends SinkListResponse> listByCondition(SinkPageRequest request) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("begin to list sink page by " + request);
}
Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
String sinkType = request.getSinkType();
Preconditions.checkNotNull(sinkType, Constant.SINK_TYPE_IS_EMPTY);`
StreamSourceServiceImpl
` public PageInfo<? extends SourceListResponse> listByCondition(SourcePageRequest request) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("begin to list source page by " + request);
}
Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
String sourceType = request.getSourceType();
Preconditions.checkNotNull(sourceType, Constant.SOURCE_TYPE_IS_EMPTY);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org