You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/06/14 15:19:14 UTC
[GitHub] [incubator-mxnet] bgawrych opened a new pull request, #21065: Fix oneDNN RNN weights reorder
bgawrych opened a new pull request, #21065:
URL: https://github.com/apache/incubator-mxnet/pull/21065
## Description ##
Fix for: https://github.com/apache/incubator-mxnet/issues/21061
Assert was triggered on machines with VNNI support. Root cause of this was not implemented reorder primitive between format_tag::ldgoi to brgemm weights,
Also added parallelization to loop for Adjusting GRU gates from MXNet format to oneDNN format
Benchmark script:
```
import mxnet as mx
import time
from itertools import product
input_sizes = [8, 32, 64]
hidden_sizes = [64, 128, 512]
num_layers = [1, 2, 3, 4]
bidirectional = [True, False]
for hidden_size, num_layers, bidirected in product(hidden_sizes, num_layers, bidirectional):
net = mx.gluon.rnn.GRU(hidden_size, num_layers=num_layers, bidirectional=bidirected)
net.initialize()
in_data = mx.nd.random.uniform(-1, 1, shape=(128, 1, hidden_size))
tic = time.time()
for i in range(10):
o = net(in_data)
o.wait_to_read()
print(f"({hidden_size},{num_layers},{bidirected});", time.time() - tic)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #21065: Fix oneDNN RNN weights reorder
Posted by GitBox <gi...@apache.org>.
bgawrych merged PR #21065:
URL: https://github.com/apache/incubator-mxnet/pull/21065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21065: Fix oneDNN RNN weights reorder
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21065:
URL: https://github.com/apache/incubator-mxnet/pull/21065#issuecomment-1160004825
Jenkins CI successfully triggered : [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21065: Fix oneDNN RNN weights reorder
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21065:
URL: https://github.com/apache/incubator-mxnet/pull/21065#issuecomment-1155343736
Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, unix-cpu, edge, website, miscellaneous, windows-gpu, centos-cpu, unix-gpu, centos-gpu, sanity, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #21065: Fix oneDNN RNN weights reorder
Posted by GitBox <gi...@apache.org>.
bgawrych commented on PR #21065:
URL: https://github.com/apache/incubator-mxnet/pull/21065#issuecomment-1160004782
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21065: Fix oneDNN RNN weights reorder
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21065:
URL: https://github.com/apache/incubator-mxnet/pull/21065#issuecomment-1161316007
For the benchmarking would be nice to see the actual results because just the difference in some time unit does not say much.
Apart from that LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org