[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10553: [Feature] Show sub-process task info in workflow definition page

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #10553:
URL: https://github.com/apache/dolphinscheduler/pull/10553#discussion_r906744632


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -398,8 +398,9 @@ public Result releaseProcessDefinition(@ApiIgnore @RequestAttribute(value = Cons
     @AccessLogAnnotation(ignoreRequestArgs = "loginUser")
     public Result queryProcessDefinitionByCode(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
                                                @ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
-                                               @PathVariable(value = "code", required = true) long code) {
-        Map<String, Object> result = processDefinitionService.queryProcessDefinitionByCode(loginUser, projectCode, code);
+                                               @PathVariable(value = "code", required = true) long code,
+                                               @RequestParam(required = false) boolean showSubTask) {
+        Map<String, Object> result = processDefinitionService.queryProcessDefinitionByCode(loginUser, projectCode, code, showSubTask);

Review Comment:
   Please add this param to the swagger's doc `@ApiImplicitParam`.



##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -27,6 +29,7 @@
 import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_DEFINE_CODE;
 import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID;
 import static org.apache.dolphinscheduler.common.Constants.LOCAL_PARAMS;
+import org.apache.dolphinscheduler.plugin.task.api.TaskConstants;

Review Comment:
   Please format this with ds checkstyle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org