You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/03/11 15:32:26 UTC
[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12714
Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
......................................................................
IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
test_max_nesting_depth works with both Orc and Parquet formats, and
needs Hive queries for data load only in the Orc case. Hive only works
with HDFS, so this test needs to be skipped if file format is Orc and
the filesystem is not HDFS.
Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
---
M tests/query_test/test_nested_types.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/12714/1
--
To view, visit http://gerrit.cloudera.org:8080/12714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Gerrit-Change-Number: 12714
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12714 )
Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
......................................................................
Patch Set 1: Code-Review+2
If we expect more tests to be excluded on the same criteria we could already add a new class to tests/common/skip.py, otherwise lgtm.
--
To view, visit http://gerrit.cloudera.org:8080/12714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Gerrit-Change-Number: 12714
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 15:48:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12714 )
Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Gerrit-Change-Number: 12714
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 20:49:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12714 )
Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3901/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Gerrit-Change-Number: 12714
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 16:31:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12714 )
Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Gerrit-Change-Number: 12714
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 16:31:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12714 )
Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
......................................................................
Patch Set 1: Code-Review+2
Thanks for the quick review!
There a several tests where all file systems are skipped with the exception of HDFS, so I think that creating a SkipIfNotHDFS makes sense. There is already a SkipIfNotHdfsMinicluster, but that does not seem appropriate for this case. A specific SkipIf that checks both file system and file format also makes sense, e.g. SkipIfNonHdfsAndHiveIsNeededToWriteFormat. I would do this in another patch, and merge this as quickly as possible. Note that IMPALA-3313 has bit different idea to improve our SkipIfs.
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/12714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Gerrit-Change-Number: 12714
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 16:28:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12714 )
Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
......................................................................
IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
test_max_nesting_depth works with both Orc and Parquet formats, and
needs Hive queries for data load only in the Orc case. Hive only works
with HDFS, so this test needs to be skipped if file format is Orc and
the filesystem is not HDFS.
Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Reviewed-on: http://gerrit.cloudera.org:8080/12714
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_nested_types.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Gerrit-Change-Number: 12714
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12714 )
Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2404/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie97166b59c451fadb33e4e780056afbaec11baa8
Gerrit-Change-Number: 12714
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 16:17:30 +0000
Gerrit-HasComments: No