You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ah...@apache.org on 2018/09/10 18:32:19 UTC

[royale-typedefs] branch develop updated: don't need patch step here either, assuming what we get from royale-extras is valid

This is an automated email from the ASF dual-hosted git repository.

aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-typedefs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 48633af  don't need patch step here either, assuming what we get from royale-extras is valid
48633af is described below

commit 48633af46db88ce091a409f9e0284f7f8c9d0f15
Author: Alex Harui <ah...@apache.org>
AuthorDate: Mon Sep 10 11:32:06 2018 -0700

    don't need patch step here either, assuming what we get from royale-extras is valid
---
 jquery/pom.xml | 29 -----------------------------
 1 file changed, 29 deletions(-)

diff --git a/jquery/pom.xml b/jquery/pom.xml
index a135760..dfebaa0 100644
--- a/jquery/pom.xml
+++ b/jquery/pom.xml
@@ -60,35 +60,6 @@
       </plugin>
 
       <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>exec-maven-plugin</artifactId>
-        <version>1.5.0</version>
-        <configuration>
-          <executable>${git.executable}</executable>
-          <workingDirectory>${basedir}/..</workingDirectory>
-          <arguments>
-            <argument>apply</argument>
-            <argument>--ignore-whitespace</argument>
-            <argument>--whitespace=nowarn</argument>
-          </arguments>
-        </configuration>
-        <executions>
-          <execution>
-            <id>patch-jquery</id>
-            <phase>validate</phase>
-            <goals>
-              <goal>exec</goal>
-            </goals>
-            <configuration>
-              <arguments combine.children="append">
-                <argument>${basedir}/src/main/patch/jquery.patch</argument>
-              </arguments>
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
-
-      <plugin>
         <groupId>org.apache.royale.compiler</groupId>
         <artifactId>royale-maven-plugin</artifactId>
         <version>${royale.compiler.version}</version>


Re: [royale-typedefs] branch develop updated: don't need patch step here either, assuming what we get from royale-extras is valid

Posted by Carlos Rovira <ca...@apache.org>.
Sorry, this seems a problem in my end. sorry for the noise.


El mar., 11 sept. 2018 a las 8:16, Carlos Rovira (<ca...@apache.org>)
escribió:

> Hi this change, make Maven build break. I'll remove it localy while is
> fixed
> thanks
>
> El lun., 10 sept. 2018 a las 20:32, <ah...@apache.org> escribió:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> aharui pushed a commit to branch develop
>> in repository https://gitbox.apache.org/repos/asf/royale-typedefs.git
>>
>>
>> The following commit(s) were added to refs/heads/develop by this push:
>>      new 48633af  don't need patch step here either, assuming what we get
>> from royale-extras is valid
>> 48633af is described below
>>
>> commit 48633af46db88ce091a409f9e0284f7f8c9d0f15
>> Author: Alex Harui <ah...@apache.org>
>> AuthorDate: Mon Sep 10 11:32:06 2018 -0700
>>
>>     don't need patch step here either, assuming what we get from
>> royale-extras is valid
>> ---
>>  jquery/pom.xml | 29 -----------------------------
>>  1 file changed, 29 deletions(-)
>>
>> diff --git a/jquery/pom.xml b/jquery/pom.xml
>> index a135760..dfebaa0 100644
>> --- a/jquery/pom.xml
>> +++ b/jquery/pom.xml
>> @@ -60,35 +60,6 @@
>>        </plugin>
>>
>>        <plugin>
>> -        <groupId>org.codehaus.mojo</groupId>
>> -        <artifactId>exec-maven-plugin</artifactId>
>> -        <version>1.5.0</version>
>> -        <configuration>
>> -          <executable>${git.executable}</executable>
>> -          <workingDirectory>${basedir}/..</workingDirectory>
>> -          <arguments>
>> -            <argument>apply</argument>
>> -            <argument>--ignore-whitespace</argument>
>> -            <argument>--whitespace=nowarn</argument>
>> -          </arguments>
>> -        </configuration>
>> -        <executions>
>> -          <execution>
>> -            <id>patch-jquery</id>
>> -            <phase>validate</phase>
>> -            <goals>
>> -              <goal>exec</goal>
>> -            </goals>
>> -            <configuration>
>> -              <arguments combine.children="append">
>> -
>> <argument>${basedir}/src/main/patch/jquery.patch</argument>
>> -              </arguments>
>> -            </configuration>
>> -          </execution>
>> -        </executions>
>> -      </plugin>
>> -
>> -      <plugin>
>>          <groupId>org.apache.royale.compiler</groupId>
>>          <artifactId>royale-maven-plugin</artifactId>
>>          <version>${royale.compiler.version}</version>
>>
>>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Re: [royale-typedefs] branch develop updated: don't need patch step here either, assuming what we get from royale-extras is valid

Posted by Carlos Rovira <ca...@apache.org>.
Hi this change, make Maven build break. I'll remove it localy while is fixed
thanks

El lun., 10 sept. 2018 a las 20:32, <ah...@apache.org> escribió:

> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-typedefs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>      new 48633af  don't need patch step here either, assuming what we get
> from royale-extras is valid
> 48633af is described below
>
> commit 48633af46db88ce091a409f9e0284f7f8c9d0f15
> Author: Alex Harui <ah...@apache.org>
> AuthorDate: Mon Sep 10 11:32:06 2018 -0700
>
>     don't need patch step here either, assuming what we get from
> royale-extras is valid
> ---
>  jquery/pom.xml | 29 -----------------------------
>  1 file changed, 29 deletions(-)
>
> diff --git a/jquery/pom.xml b/jquery/pom.xml
> index a135760..dfebaa0 100644
> --- a/jquery/pom.xml
> +++ b/jquery/pom.xml
> @@ -60,35 +60,6 @@
>        </plugin>
>
>        <plugin>
> -        <groupId>org.codehaus.mojo</groupId>
> -        <artifactId>exec-maven-plugin</artifactId>
> -        <version>1.5.0</version>
> -        <configuration>
> -          <executable>${git.executable}</executable>
> -          <workingDirectory>${basedir}/..</workingDirectory>
> -          <arguments>
> -            <argument>apply</argument>
> -            <argument>--ignore-whitespace</argument>
> -            <argument>--whitespace=nowarn</argument>
> -          </arguments>
> -        </configuration>
> -        <executions>
> -          <execution>
> -            <id>patch-jquery</id>
> -            <phase>validate</phase>
> -            <goals>
> -              <goal>exec</goal>
> -            </goals>
> -            <configuration>
> -              <arguments combine.children="append">
> -
> <argument>${basedir}/src/main/patch/jquery.patch</argument>
> -              </arguments>
> -            </configuration>
> -          </execution>
> -        </executions>
> -      </plugin>
> -
> -      <plugin>
>          <groupId>org.apache.royale.compiler</groupId>
>          <artifactId>royale-maven-plugin</artifactId>
>          <version>${royale.compiler.version}</version>
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira