You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/20 02:56:19 UTC

[GitHub] [incubator-nuttx] donghengqaz opened a new pull request #1431: fs/nxffs: Fix scan good block slowly and scan an invalid block

donghengqaz opened a new pull request #1431:
URL: https://github.com/apache/incubator-nuttx/pull/1431


   ## Summary
   
   I am in charge of porting ESP32 SPI flash driver to NuttX, and I develop it as MTD. I mount the SPI Flash MTD to NxFFS, then test it with nuttx-app/fstest.
   
   The first testing is success, but the second testing fail. I open the debug information and found that the scanning function find the invalid "block" as start block and write data fail.
   
   I add the following scanning algorithm:
   
   1. scan the block to find "block header"
   2. at offset 5 of block, try to find continue 128 data of 0xff
   3. if fail. then read next block
   
   ## Impact
   
   1. scan faster
   2. fix scanning an invalid block
   
   ## Testing
   
   Test nuttx-app/fstest for multi time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1431: fs/nxffs: Fix scan good block slowly and scan an invalid block

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1431:
URL: https://github.com/apache/incubator-nuttx/pull/1431#issuecomment-660775547


   @donghengqaz could you fix nxstyle warning:
   https://github.com/apache/incubator-nuttx/pull/1431/checks?check_run_id=888265746


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #1431: fs/nxffs: Fix scan good block slowly and scan an invalid block

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1431:
URL: https://github.com/apache/incubator-nuttx/pull/1431


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org