You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "shunping-google (via GitHub)" <gi...@apache.org> on 2023/08/30 18:45:54 UTC
[GitHub] [beam] shunping-google opened a new issue, #28235: [Go SDK] lint warning from Golint
shunping-google opened a new issue, #28235:
URL: https://github.com/apache/beam/issues/28235
The lint warning of `exported method W.Connected should have comment or be unexported` is reported In the following code: https://github.com/apache/beam/blob/c7b13f90874940dd0e897eab472e81f70627e91f/sdks/go/pkg/beam/runners/prism/internal/worker/worker.go#L249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on issue #28235: [Go SDK] lint warning from Golint
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on issue #28235:
URL: https://github.com/apache/beam/issues/28235#issuecomment-1699839355
Thanks!
Yeah, I'm fixing this in my next PR. Consolidated failures will make the flow easier to follow.
Ideally, a failure can only come after a bundle errors out, and then this can resolve retries cleanly at a later stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Go SDK] lint warning from Golint [beam]
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on issue #28235:
URL: https://github.com/apache/beam/issues/28235#issuecomment-1789811586
The specific instance has been resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on issue #28235: [Go SDK] lint warning from Golint
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on issue #28235:
URL: https://github.com/apache/beam/issues/28235#issuecomment-1699668315
I was going to make a run at this but there's enough going on here that I'll hold off. @lostluck FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Go SDK] lint warning from Golint [beam]
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck closed issue #28235: [Go SDK] lint warning from Golint
URL: https://github.com/apache/beam/issues/28235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org