You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/27 15:53:09 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #350: [DRAFT] version-number-in-build
pjfanning opened a new pull request, #350:
URL: https://github.com/apache/incubator-pekko/pull/350
* not yet to be merged
* for discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #350: doc: how to set version number in build
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #350:
URL: https://github.com/apache/incubator-pekko/pull/350#issuecomment-1566093202
Would it be a big deal to document both approaches (you can mention the easier approach at the start)? Alternately I can also document the second approach myself after this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #350: doc: how to set version number in build
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #350:
URL: https://github.com/apache/incubator-pekko/pull/350#discussion_r1208602141
##########
README.md:
##########
@@ -39,6 +39,12 @@ See https://pekko.apache.org for the documentation including the API docs. The d
- the `index.html` file will appear in `target/paradox/site/main/`
- `sbt unidoc` will build the Javadocs for all the modules and load them to one place (may require Graphviz, see Prerequisites above)
- the `index.html` file will appear in `target/scala-2.13/unidoc/`
+- `sbt sourceDistGenerate` will generate source release to `target/dist/`
+- The version number that appears in filenames and docs is derived, by default. The derived version contains the most git commit id or the date/time (if the directory is not under got control).
Review Comment:
type here, `under got control` should be `under git control`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #350: doc: how to set version number in build
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #350:
URL: https://github.com/apache/incubator-pekko/pull/350#issuecomment-1566129850
@mdedetrich I made some changes. I'll leave this open for a few days to facilitate discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #350: doc: how to set version number in build
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #350:
URL: https://github.com/apache/incubator-pekko/pull/350#issuecomment-1566092898
> Is there a reason why you don't want to document doing [#339 (comment)](https://github.com/apache/incubator-pekko/issues/339#issuecomment-1561848206) ? Its far easier than having to create a file (which makes the source dirty)
* these notes are really aimed at the Incubator PMC voters - the majority of whom are not Scala or sbt users
* the source release when unzipped is not under git control
* adding the file once means that you don't need to set it the prop in every sbt call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #350: doc: how to set version number in build
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #350:
URL: https://github.com/apache/incubator-pekko/pull/350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #350: doc: how to set version number in build
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #350:
URL: https://github.com/apache/incubator-pekko/pull/350#discussion_r1208602859
##########
README.md:
##########
@@ -39,6 +39,12 @@ See https://pekko.apache.org for the documentation including the API docs. The d
- the `index.html` file will appear in `target/paradox/site/main/`
- `sbt unidoc` will build the Javadocs for all the modules and load them to one place (may require Graphviz, see Prerequisites above)
- the `index.html` file will appear in `target/scala-2.13/unidoc/`
+- `sbt sourceDistGenerate` will generate source release to `target/dist/`
+- The version number that appears in filenames and docs is derived, by default. The derived version contains the most git commit id or the date/time (if the directory is not under got control).
Review Comment:
thanks - fixed the typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #350: doc: how to set version number in build
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #350:
URL: https://github.com/apache/incubator-pekko/pull/350#issuecomment-1566087021
Is there a reason why you don't want to document doing https://github.com/apache/incubator-pekko/issues/339#issuecomment-1561848206 ? Its far easier than having to create a file (which makes the source dirty)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #350: doc: how to set version number in build
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #350:
URL: https://github.com/apache/incubator-pekko/pull/350#discussion_r1208602141
##########
README.md:
##########
@@ -39,6 +39,12 @@ See https://pekko.apache.org for the documentation including the API docs. The d
- the `index.html` file will appear in `target/paradox/site/main/`
- `sbt unidoc` will build the Javadocs for all the modules and load them to one place (may require Graphviz, see Prerequisites above)
- the `index.html` file will appear in `target/scala-2.13/unidoc/`
+- `sbt sourceDistGenerate` will generate source release to `target/dist/`
+- The version number that appears in filenames and docs is derived, by default. The derived version contains the most git commit id or the date/time (if the directory is not under got control).
Review Comment:
typo here, `under got control` should be `under git control`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org