You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by David Mackey <td...@booleanhaiku.com> on 2013/09/25 23:56:13 UTC

Review Request 14336: stout: resolve read() resource leak.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14336/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Repository: mesos-git


Description
-------

Stout os::read buffer leaks. Clean it up.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 0c5b2ef 

Diff: https://reviews.apache.org/r/14336/diff/


Testing
-------


Thanks,

David Mackey


Re: Review Request 14336: stout: resolve read() resource leak.

Posted by Ben Mahler <be...@gmail.com>.

> On Sept. 25, 2013, 9:57 p.m., Ben Mahler wrote:
> > Thank you!

Please mark as submitted!


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14336/#review26391
-----------------------------------------------------------


On Sept. 25, 2013, 9:57 p.m., David Mackey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14336/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Stout os::read buffer leaks. Clean it up.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 0c5b2ef 
> 
> Diff: https://reviews.apache.org/r/14336/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> David Mackey
> 
>


Re: Review Request 14336: stout: resolve read() resource leak.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14336/#review26391
-----------------------------------------------------------

Ship it!


Thank you!

- Ben Mahler


On Sept. 25, 2013, 9:57 p.m., David Mackey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14336/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Stout os::read buffer leaks. Clean it up.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 0c5b2ef 
> 
> Diff: https://reviews.apache.org/r/14336/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> David Mackey
> 
>


Re: Review Request 14336: stout: resolve read() resource leak.

Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14336/
-----------------------------------------------------------

(Updated Sept. 25, 2013, 9:57 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Repository: mesos-git


Description
-------

Stout os::read buffer leaks. Clean it up.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 0c5b2ef 

Diff: https://reviews.apache.org/r/14336/diff/


Testing (updated)
-------

make check


Thanks,

David Mackey