[GitHub] [hive] b-slim commented on a change in pull request #909: HIVE-22821

[GitBox <gi...@apache.org>]

b-slim commented on a change in pull request #909: HIVE-22821
URL: https://github.com/apache/hive/pull/909#discussion_r389020955
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
 ##########
 @@ -221,6 +227,9 @@ public void debugDumpShort(StringBuilder sb) {
         metadataCache, dataCache, bufferManagerOrc, conf, cacheMetrics, ioMetrics, tracePool);
     this.genericCvp = isEncodeEnabled ? new GenericColumnVectorProducer(
         serdeCache, bufferManagerGeneric, conf, cacheMetrics, ioMetrics, tracePool) : null;
+    proactiveEvictionExecutor = Executors.newSingleThreadExecutor(
 
 Review comment:
   @szlta , if for every new feature we add a new thread pool then the code will become a huge burden to maintain. The RPC thread pool is meant for that doing the stuff within  thread of the pool that can be increased if needed. By creating a new pool we are not changing anything just adding more burden from code perspective.  Same on the HS2I user will need to wait and see the result of the command same with the purge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org