[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #4656: tcp: fixed issues with unackseq calculation.

[GitBox <gi...@apache.org>]

a-lunev commented on a change in pull request #4656:
URL: https://github.com/apache/incubator-nuttx/pull/4656#discussion_r726185514



##########
File path: net/tcp/tcp_input.c
##########
@@ -1031,11 +1027,9 @@ static void tcp_input(FAR struct net_driver_s *dev, uint8_t domain,
               {
                 conn->tcpstateflags = TCP_LAST_ACK;
                 conn->tx_unacked    = 1;
+                conn->sndseq_max    = tcp_getsequence(conn->sndseq) + 1;

Review comment:
       Do you mean the order of the lines?
   I have moved setting conn->sndseq_max variable close to setting conn->tx_unacked variable line by line. These two variables should be modified as a pair (it's wrong if only one of the two variables is modified and the other is not, like it was before my patch (setting conn->sndseq_max variable was isolated by a conditional compilation)). Functionally the order of these lines do not affect anything. I have placed these lines near to each other just because I consider this more logical.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org