[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3794: ARTEMIS-3461 provide a more native AMQP message represention in browse-queue

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #3794:
URL: https://github.com/apache/activemq-artemis/pull/3794#discussion_r728659828



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/openmbean/OpenTypeSupport.java
##########
@@ -302,4 +316,30 @@ protected void init() throws OpenDataException {
          return rc;
       }
    }
+
+	static class AmqpMessageOpenTypeFactory extends MessageOpenTypeFactory {
+		protected ArrayType body;
+
+		@Override
+		protected void init() throws OpenDataException {
+			super.init();
+			addItem(CompositeDataConstants.TEXT_BODY, CompositeDataConstants.TEXT_BODY, SimpleType.STRING);
+		}
+
+		@Override
+		public Map<String, Object> getFields(MessageReference ref, int valueSizeLimit) throws OpenDataException {
+			Map<String, Object> rc = super.getFields(ref, valueSizeLimit);
+
+			AMQPStandardMessage amqpMessage = ((AMQPStandardMessage) ref.getMessage());

Review comment:
       The intent of protocol support is theyre a layer and self contained within their protocol modules, else we end up having all protocols just mis matching all over the place. Can we look to abstract out and interface whats needed in core server so that protocols can extend and then have protocol specifics in protocol module.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org