You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Dieter Wimberger (JIRA)" <ji...@apache.org> on 2008/06/01 07:46:44 UTC
[jira] Created: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
-------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: FELIX-587
URL: https://issues.apache.org/jira/browse/FELIX-587
Project: Felix
Issue Type: Bug
Components: Web Console
Reporter: Dieter Wimberger
A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
Fix:
The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-587:
------------------------------------
Attachment: FELIX-587-fmeschbe.patch
Patch modifying ConfigManagerBase.getObjectClassDefinition method to consider the factory PID if not null otherwise to only consider the PID.
WDYT ?
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-587
> URL: https://issues.apache.org/jira/browse/FELIX-587
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Attachments: AjaxConfigManagerAction.java.diff, FELIX-587-fmeschbe.patch
>
>
> A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> Fix:
> The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned FELIX-587:
---------------------------------------
Assignee: Felix Meschberger
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-587
> URL: https://issues.apache.org/jira/browse/FELIX-587
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Assignee: Felix Meschberger
> Fix For: webconsole-1.0.2
>
> Attachments: AjaxConfigManagerAction.java.diff, FELIX-587-fmeschbe.patch
>
>
> A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> Fix:
> The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Dieter,
Am Freitag, den 13.06.2008, 15:15 -0700 schrieb Dieter Wimberger (JIRA):
> The way you approached to fix the chain of issues I reported (sorry for the messed up patch), it occurs difficult to me to track them properly. Also, I have a question for you:
> Do you actually have a test case? If yes, which one is it?
My test case in Apache Sling, where I have a number of factory
configurations, with which I test.
And yes, your series of issues makes this whole a bit difficult to
track, because I did not set out to fix the "old" implementation but
create an entirely new implementation by completely separating the
handling of factories and actual configuration instances.
It also seems, that you are testing with Equinox MetaType and
Configuration Admin, right ? If so, we might also be tackling some
issues with differing implementations of the spec. I will try to figure
out, what is going on, by using the Equinox implementations...
Regards
Felix
Re: [jira] Commented: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
Am Freitag, den 13.06.2008, 15:15 -0700 schrieb Dieter Wimberger (JIRA):
> There is a corresponding metatype description.
>
> The way you approached to fix the chain of issues I reported (sorry for the messed up patch), it occurs difficult to me to track them properly. Also, I have a question for you:
> Do you actually have a test case? If yes, which one is it?
I now tested my last patches against Equinox MetaType and Configuration
Admin service implementations and found out that Equinox Configuration
Admin does not persist created factory configurations until first
updated whereas the Apache Felix implementation immediately persists
such created configurations.
So, now the configuration is correctly displayed by the configuration
admin...
Regards
Felix
>
> Regards,
> Dieter
>
>
>
>
> > org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> > -------------------------------------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: FELIX-587
> > URL: https://issues.apache.org/jira/browse/FELIX-587
> > Project: Felix
> > Issue Type: Bug
> > Components: Web Console
> > Reporter: Dieter Wimberger
> > Attachments: AjaxConfigManagerAction.java.diff, FELIX-587-fmeschbe.patch
> >
> >
> > A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> > Fix:
> > The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
>
[jira] Commented: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by "Dieter Wimberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604990#action_12604990 ]
Dieter Wimberger commented on FELIX-587:
----------------------------------------
I have checked out a fresh working copy.
Creation is possible, but it does not seem to work properly, because it reports:
This configuration has no associated description
Here are the values returned from the Ajax call:
{"pid":"net.wimpi.telnetd.service.TelnetListenerServiceFactory-1213394666652-2","isFactory":false,"title"
:"net.wimpi.telnetd.service.TelnetListenerServiceFactory-1213394666652-2","description":"Please enter
configuration properties for this configuration in the field below. This configuration has no associated
description","propertylist":"properties","properties":{}}
There is a corresponding metatype description.
The way you approached to fix the chain of issues I reported (sorry for the messed up patch), it occurs difficult to me to track them properly. Also, I have a question for you:
Do you actually have a test case? If yes, which one is it?
Regards,
Dieter
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-587
> URL: https://issues.apache.org/jira/browse/FELIX-587
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Attachments: AjaxConfigManagerAction.java.diff, FELIX-587-fmeschbe.patch
>
>
> A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> Fix:
> The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-587:
------------------------------------
Fix Version/s: webconsole-1.0.2
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-587
> URL: https://issues.apache.org/jira/browse/FELIX-587
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Fix For: webconsole-1.0.2
>
> Attachments: AjaxConfigManagerAction.java.diff, FELIX-587-fmeschbe.patch
>
>
> A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> Fix:
> The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by "Dieter Wimberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dieter Wimberger resolved FELIX-587.
------------------------------------
Resolution: Fixed
The updated version of the webconsole takes a different approach, but resolves this issue.
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-587
> URL: https://issues.apache.org/jira/browse/FELIX-587
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Attachments: AjaxConfigManagerAction.java.diff, FELIX-587-fmeschbe.patch
>
>
> A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> Fix:
> The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by "Dieter Wimberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dieter Wimberger closed FELIX-587.
----------------------------------
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-587
> URL: https://issues.apache.org/jira/browse/FELIX-587
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Attachments: AjaxConfigManagerAction.java.diff, FELIX-587-fmeschbe.patch
>
>
> A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> Fix:
> The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by "Dieter Wimberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dieter Wimberger updated FELIX-587:
-----------------------------------
Attachment: AjaxConfigManagerAction.java.diff
Obtained using:
svn diff AjaxConfigManagerAction.java > AjaxConfigManagerAction.java.diff
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-587
> URL: https://issues.apache.org/jira/browse/FELIX-587
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Attachments: AjaxConfigManagerAction.java.diff
>
>
> A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> Fix:
> The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-587)
org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm():
Configuration instance for a ManagedServiceFactory will cause Exception
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604802#action_12604802 ]
Felix Meschberger commented on FELIX-587:
-----------------------------------------
AFAIK the ConfigManagerBase.getObjectClassDefinition() takes care of looking at the object class definition for the factory PID if there is no object class definition for the PID.
On the other hand your patch only looks at the object class definition for the factory PID ignoring the PID altogether. While this is certainly not wrong, I wonder what the exact problem is you are getting.
And if we agree, that for a configuration with a factory PID only the that value should be considered for finding an object class definition I would rather prefer a different patch, which I will attach.
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-587
> URL: https://issues.apache.org/jira/browse/FELIX-587
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Attachments: AjaxConfigManagerAction.java.diff
>
>
> A Configuration instance for a ManagedServiceFactory will cause an Exception in org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(), because the implementation will try to obtain an ObjectClassDefinition for the Configuration pid, rather than for the corresponding factoryPid.
> Fix:
> The method should verify if a factoryPid is assigned to the Configuration instance and handle this case properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.