You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2025/09/04 12:40:53 UTC
[PR] SOLR-17864: Migrate more system properties [solr]
epugh opened a new pull request, #3617:
URL: https://github.com/apache/solr/pull/3617
https://issues.apache.org/jira/browse/SOLR-17864
solr.dns.prevent.reverse.lookup
solr.auth.jwt.allow.outbound.http
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17864: Migrate more system properties [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #3617:
URL: https://github.com/apache/solr/pull/3617#discussion_r2323692568
##########
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##########
@@ -77,7 +78,7 @@ public class SystemInfoHandler extends RequestHandlerBase {
* @see #initHostname
*/
private static final String PREVENT_REVERSE_DNS_OF_LOCALHOST_SYSPROP =
- "solr.dns.prevent.reverse.lookup";
+ "solr.admin.handler.systeminfo.dns.prevent.reverse.lookup.enabled";
Review Comment:
The "enabled" suffix exposes an inversion of expressing what we're going to do. Arguably boolean settings should express what we *will* do, which aligns with your opinionated stance on using "enabled" instead of "disabled". Thus we could drop the "prevent" there and flip the meaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17864: Migrate more system properties [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #3617:
URL: https://github.com/apache/solr/pull/3617#issuecomment-3254073391
I think this batch is ready for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17864: Migrate more system properties [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #3617:
URL: https://github.com/apache/solr/pull/3617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17864: Migrate more system properties [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #3617:
URL: https://github.com/apache/solr/pull/3617#discussion_r2323862636
##########
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##########
@@ -77,7 +78,7 @@ public class SystemInfoHandler extends RequestHandlerBase {
* @see #initHostname
*/
private static final String PREVENT_REVERSE_DNS_OF_LOCALHOST_SYSPROP =
- "solr.dns.prevent.reverse.lookup";
+ "solr.admin.handler.systeminfo.dns.prevent.reverse.lookup.enabled";
Review Comment:
Love it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org