You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by elsloo <gi...@git.apache.org> on 2017/02/06 22:08:32 UTC
[GitHub] incubator-trafficcontrol pull request #256: [TC-136] Fixes a logic bug that ...
GitHub user elsloo opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/256
[TC-136] Fixes a logic bug that prevented the easy case for finding b\u2026
\u2026ond speed, and handle the case where the CentOS 7.3 3.10.0-514 kernel uses lower_X as a pointer to enslaved interfaces, while retaining the slave_X case from earlier kernels.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elsloo/incubator-trafficcontrol 2.0.x_astats_bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #256
----
commit 5eda5cd2cd6314879c4624891581b9181350b0d5
Author: Jeff Elsloo <je...@cable.comcast.com>
Date: 2017-02-06T22:07:20Z
[TC-136] Fixes a logic bug that prevented the easy case for finding bond speed, and handle the case where the CentOS 7.3 3.10.0-514 kernel uses lower_X as a pointer to enslaved interfaces, while retaining the slave_X case from earlier kernels.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...
Posted by smalenfant <gi...@git.apache.org>.
Github user smalenfant commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/256
@elsloo I haven't tried but I believe it will fail on... Have you taken a look at the PR I made against yours?
```
if (TSPluginRegister(&info) != TS_SUCCESS)
TSError("Plugin registration failed. \n");
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/256
@smalenfant I made changes to the PR to build against 5.3.2, and tested that it builds successfully.
```
[root@localhost astats_over_http]# /opt/trafficserver/bin/tsxs -c astats_over_http.c -o astats_over_http.so
compiling astats_over_http.c -> astats_over_http.lo
linking -> astats_over_http.so
[root@localhost astats_over_http]# rpm -q trafficserver
trafficserver-5.3.2-765.f4354b9.el7.centos.x86_64
[root@localhost astats_over_http]#
```
Let me know if this works for you and solves the original issue. Apologies for the confusion around the ATS version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #256: [TC-136] Fixes a logic bug that ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...
Posted by smalenfant <gi...@git.apache.org>.
Github user smalenfant commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/256
There is a possibility that you might have some patches against your 5.3.x that might make this work. But it won't compile against 5.3.2 provided by Traffic Server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/256
I did see your PR. Did you look at the full PR after my latest commit? We check the version and return if it's not correct following the plugin registration. As far as I know, this is the same code we're running in production.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/256
@smalenfant I spoke to Rushford and found that our copy in master is based on 6.2, so I'll be making more corrections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...
Posted by smalenfant <gi...@git.apache.org>.
Github user smalenfant commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/256
@elsloo Sorry I couldn't get to this before, but it still fails compiling on 5.3.2. Please look at the PR I've made against yours to prevents this.
```
[vagrant@build-ats-7 test]$ /opt/trafficserver/bin/tsxs -c astats_over_http.c -o astats_over_http.so
compiling astats_over_http.c -> astats_over_http.lo
astats_over_http.c: In function \u2018TSPluginInit\u2019:
astats_over_http.c:543:2: error: incompatible type for argument 1 of \u2018TSPluginRegister\u2019
if (TSPluginRegister(&info) != TS_SUCCESS)
^
In file included from astats_over_http.c:29:0:
/opt/trafficserver/include/ts/ts.h:158:20: note: expected \u2018TSSDKVersion\u2019 but argument is of type \u2018struct TSPluginRegistrationInfo *\u2019
tsapi TSReturnCode TSPluginRegister(TSSDKVersion sdk_version, TSPluginRegistrationInfo *plugin_info);
^
astats_over_http.c:543:2: error: too few arguments to function \u2018TSPluginRegister\u2019
if (TSPluginRegister(&info) != TS_SUCCESS)
^
In file included from astats_over_http.c:29:0:
/opt/trafficserver/include/ts/ts.h:158:20: note: declared here
tsapi TSReturnCode TSPluginRegister(TSSDKVersion sdk_version, TSPluginRegistrationInfo *plugin_info);
^
tsxs: compilation failed: cc -I/opt/trafficserver/include -g -pipe -Wall -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -mcx16 -fpic -c astats_over_http.c -o astats_over_http.lo
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---