You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/19 02:35:36 UTC

[GitHub] [incubator-dolphinscheduler] 1445103710 opened a new pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

1445103710 opened a new pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754


   …yTaskInstanceId #2745
   
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   This pull request adds remove taskExecutionContextCacheManager cache
   
   ## Brief change log
   
   *(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   add remove taskExecutionContextCacheManager to TaskExecuteThread
   add remove taskExecutionContextCacheManager to TaskKillProcessor
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as *(TaskCallbackServiceTest)*.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

dailidong commented on pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754#issuecomment-636292940


   if UT go through, i will merge it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

dailidong commented on pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754#issuecomment-636292859


   the bug in the dev-1.3.0 will be more attentive and reviewed quickly, so I  reopen this PR
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

dailidong commented on pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754#issuecomment-636301151


   Unit Test failed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

dailidong commented on pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754#issuecomment-636302253


   > Unit Test failed
   
   failed ut not relevant about this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] 1445103710 closed pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

1445103710 closed pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

dailidong commented on pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754#issuecomment-636346325


   thanks for your first contribution，looking forward for your next contribution, if you need help, please contact me through mail or add my wechat(510570367), when added, please tell me your github id, thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

dailidong merged pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

dailidong closed pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] gabrywu commented on pull request #2754: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…

Posted by GitBox <gi...@apache.org>.

gabrywu commented on pull request #2754:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2754#issuecomment-632487750


   @1445103710  Can you close the duplicated PR and resolve the Unit Test error?
   https://github.com/apache/incubator-dolphinscheduler/pull/2752


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org