[jira] [Comment Edited] (PHOENIX-5771) Make standalone queryserver assembly useful again

["Istvan Toth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060628#comment-17060628 ] 

Istvan Toth edited comment on PHOENIX-5771 at 3/17/20, 4:32 AM:
----------------------------------------------------------------

We cannot add the thick client JAR to the PQS library, as we don't know in advance what version of Phoenix is used, and we should also support updating PQS and Phoenix separately, as the releases are probably not going to be synced.

The same goes for adding PQS to the Phoenix assembly. Doing that would also defeat the point of splitting PQS from the main repos as well.

My current plan is to support these scenarios:
 * Have the user manually install the assembly into the same dir as Phoenix, where PQS will find the thick client JAR automatically
 * Just ask the user to copy/link the client jar into the PQS root or lib directory manually.
 * (We can also check an environment variable for the full path+filename of the thick client )


was (Author: stoty):
We cannot add the thick client JAR to the PQS library, as we don't know in advance what version of Phoenix is used, and we should also support updating PQS and Phoenix separately, as the releases are probably not going to be synced.

The same goes for adding PQS to the Phoenix assembly. Doing that would also defeat the point of splitting PQS from the main repos as well.

My current plan is to support these scenarios:
 * Have the user manually install the assembly into the same dir as Phoenix, where Phoenix will find the thick client JAR automatically
 * Just ask the user to copy/link the client jar into the PQS root or lib directory manually.
 * (We can also check an environment variable for the full path+filename of the thick client )

> Make standalone queryserver assembly useful again
> -------------------------------------------------
>
>                 Key: PHOENIX-5771
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5771
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> The assembly module in the phoenix-queryserver repo doesn't make much sense as it is.
> Things to do:
>  * figure out the use case for the assembly: 
>  ** Do we want this to be copied onto the main phoenix assembly (my preferred answer)
>  ** Or do we want it to live in standalone driectory
>  * Copy the right jars to the right place for the scripts to work
>  * Make sure we do not overwrite stuff in the main repo (if we share the install dir)
>  * Make sure PQS can access the fat client JAR ( an issue if we want to live standalone)
>  * Remove PQS cruft from the main Phoenix scripts and vica versa (probably in a different JIRA)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)