[jira] Commented: (MAVEN-373) Incorrect arguments in jar:deploy and jar:deploy-snapshot

[ji...@codehaus.org]

The following comment has been added to this issue:

     Author: Marc Portier
    Created: Tue, 14 Oct 2003 11:19 AM
       Body:
A bit confused about the status of this bug...

I experienced the same behaviour expressed here:
first argument to scp is empty when doing the jar:deploy-snapshot in combination with a -Dmaven.build.dir

The bug-detail seemed to tell me there is a fix in jar-1.1 however:

after getting the 1.1 with:

$ maven -DgroupId=maven -DartifactId=maven-jar-plugin -Dversion=1.1 plugin:download


the execution of:
$ maven -X -Dmaven.username=mpo -Dmaven.remote.group=users -Dmaven.repo.central=otsrv1 
-Dmaven.repo.central.directory=public_html/maven -Dmaven.build.dir=build jar:deploy-snapshot


still renders:

    [exec] [VERBOSE] Executing 'scp' with arguments:
''
'mpo@otsrv1:public_html/maven/tryouts/jars'


in stead off:

    [exec] [DEBUG] Execute:Java13CommandLauncher: Executing 'scp' with arguments:
'target/maven_tryout-20031014.155338.jar'
'mpo@otsrv1:public_html/maven/tryouts/jars'

(the latter when I leave out the maven.build.dir setting)


regards,
-marc=
---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-373


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-373
    Summary: Incorrect arguments in jar:deploy and jar:deploy-snapshot
       Type: Bug

     Status: Unassigned
   Priority: Major

 Time Spent: Unknown
  Remaining: Unknown

    Project: maven
 Components: 
             plugin-java
   Fix Fors:
             1.1
   Versions:
             1.0-beta-9

   Assignee: 
   Reporter: Aslak Hellesoy

    Created: Fri, 4 Apr 2003 6:31 AM
    Updated: Mon, 4 Aug 2003 11:26 AM

Description:
The jar:deploy and jar:deploy-snapshot goals are doing some fancy and unnecessary string manipulations to find the relative file name of the jar file to deploy.

This is unnecessary (the file name of the jars can be absolute), and furhter, it doesn't work when ${maven.build.dir} is overridden to point outside the project.

Further, the jar:deploy-snapshot could just call the jar:deploy goal (and avoid copy-paste of identical logic).

The mentioned goals should be simplified as follows:

  <!-- ================================================================== -->
  <!-- D E P L O Y  S N A P S H O T                                       -->
  <!-- ================================================================== -->

  <goal
    name="jar:deploy-snapshot"
    description="Deploy a snapshot jar to the remote repository">

    <m:user-check user="${maven.username}"/>
    <attainGoal name="jar:snapshot"/>
    <attainGoal name="jar:deploy"/>
                    
  </goal>

  <!-- ================================================================== -->
  <!-- D E P L O Y  J A R                                                 -->
  <!-- ================================================================== -->

  <goal
    name="jar:deploy"
    description="Deploy a jar to the remote repository">

    <m:user-check user="${maven.username}"/>
    <attainGoal name="java:jar"/>
    <ant:property name="maven.jar.to.deploy" value="${maven.final.name}.jar"/>
    <deploy:artifact
      artifact="${maven.final.name}.jar"
      type="jars"
      assureDirectoryCommand="mkdir -p"
      siteCommand="cd @deployDirectory@; chmod g+w ${maven.jar.to.deploy}; chgrp maven ${maven.jar.to.deploy}"
    />

  </goal>



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org