You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/04/14 23:02:00 UTC
[jira] [Commented] (IMPALA-9651) Update Ranger Impala plugin to
replace use of deprecated APIs
[ https://issues.apache.org/jira/browse/IMPALA-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083679#comment-17083679 ]
ASF subversion and git services commented on IMPALA-9651:
---------------------------------------------------------
Commit 9ea8b1454fabf5872459cd8ae6af60e8d89f62a5 in impala's branch refs/heads/master from Fang-Yu Rao
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9ea8b14 ]
IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
RangerAuthContext#getResourceACLs() was deprecated due to a recent
change in RANGER-2654 and the constructor
RangerRESTClient(String, String) of the class RangerRESTClient was
also recently deprecated in RANGER-2646. This patch replaces the
references to these two methods with the updated APIs respectively.
Testing:
- Verified that this patch passes the exhaustive tests in the DEBUG
build.
Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Reviewed-on: http://gerrit.cloudera.org:8080/15731
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Update Ranger Impala plugin to replace use of deprecated APIs
> -------------------------------------------------------------
>
> Key: IMPALA-9651
> URL: https://issues.apache.org/jira/browse/IMPALA-9651
> Project: IMPALA
> Issue Type: Task
> Reporter: Fang-Yu Rao
> Assignee: Fang-Yu Rao
> Priority: Major
>
> Ranger Impala plugin currently uses couple of deprecated Ranger APIs. These need to be replaced as detailed below.
> 1. RangerImpaladAuthorizationManager has reference to method {{RangerAuthContext.getResourceACLs()}}, which was deprecated with recent changes in RANGER-2654. This reference should be replaced with a call to {{RangerBasePlugin.getResourceACLs()}}, as shown below.
> Current call:
> {noformat}
> RangerResourceACLs acls = authContext_.get().getResourceACLs(request);
> {noformat}
> Should be updated to:
> {noformat}
> RangerResourceACLs acls = plugin_.get().getResourceACLs(request);
> {noformat}
> Also, {{authContext_}} can be removed from RangerImpaladAuthorizationManager, as this member will not be needed anymore.
> 2. AuthorizationTestBase has reference to method {{RangerRESTClient(String, String)}}, which was deprecated with recent changes in RANGER-2646. This reference should be replaced with a call to {{RangerRESTClient(String, String, Configuration)}}, as shown below:
> Current call:
> {noformat}
> rangerRestClient_ = new RangerRESTClient(RANGER_ADMIN_URL, null);
> {noformat}
> Should be updated to:
> {noformat}
> rangerRestClient_ = new RangerRESTClient(RANGER_ADMIN_URL, null, rangerImpalaPlugin_.getConfig());
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org