You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/26 10:38:12 UTC

[GitHub] [spark] MaxGekk opened a new pull request, #36359: [WIP][SQL] Output SQL statements in upper case in error messages

MaxGekk opened a new pull request, #36359:
URL: https://github.com/apache/spark/pull/36359

   ### What changes were proposed in this pull request?
   In the PR, I propose to output any SQL statement in error messages in upper case, and apply new implementation of `QueryErrorsBase.toSQLStmt()` to all exceptions in `Query.*Errors` w/ error classes. Also this PR modifies all affected tests, see the list in the section "How was this patch tested?".
   
   ### Why are the changes needed?
   To improve user experience with Spark SQL by highlighting SQL statements in error massage and make them more visible to users. Also this PR makes SQL statements in error messages consistent to the docs where such elements are showed in upper case w/ any quotes.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. The changes might influence on error messages:
   
   Before:
   ```sql
   The operation "DESC PARTITION" is not allowed
   ```
   
   After:
   ```sql
   The operation DESC PARTITION is not allowed
   ```
   
   ### How was this patch tested?
   By running affected test suites:
   ```
   $ build/sbt "sql/testOnly *QueryExecutionErrorsSuite"
   $ build/sbt "sql/testOnly *QueryParsingErrorsSuite"
   $ build/sbt "sql/testOnly *QueryCompilationErrorsSuite"
   $ build/sbt "test:testOnly *QueryCompilationErrorsDSv2Suite"
   $ build/sbt "test:testOnly *ExtractPythonUDFFromJoinConditionSuite"
   $ build/sbt "testOnly *PlanParserSuite"
   $ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z transform.sql"
   $ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z join-lateral.sql"
   $ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z describe.sql"
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #36359: [SPARK-39027][SQL] Output SQL statements in error messages in upper case and w/o double quotes

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36359:
URL: https://github.com/apache/spark/pull/36359#issuecomment-1110239459

   cc @srielau 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #36359: [SPARK-39027][SQL] Output SQL statements in upper case in error messages

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36359:
URL: https://github.com/apache/spark/pull/36359#issuecomment-1109947617

   @cloud-fan @srielau @HyukjinKwon Could you approve remove double quotes around SQL statements in error messages, please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #36359: [SPARK-39027][SQL] Output SQL statements in error messages in upper case and w/o double quotes

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36359:
URL: https://github.com/apache/spark/pull/36359#issuecomment-1110778063

   All GAs passed: https://github.com/MaxGekk/spark/runs/6189050094. Merging to master.
   Thank you, @HyukjinKwon @cloud-fan for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk closed pull request #36359: [SPARK-39027][SQL] Output SQL statements in error messages in upper case and w/o double quotes

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36359: [SPARK-39027][SQL] Output SQL statements in error messages in upper case and w/o double quotes
URL: https://github.com/apache/spark/pull/36359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org