You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "stuhood (via GitHub)" <gi...@apache.org> on 2026/03/31 05:02:27 UTC
[PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
stuhood opened a new pull request, #21267:
URL: https://github.com/apache/datafusion/pull/21267
## Which issue does this PR close?
- Closes #20443.
## Rationale for this change
This change fixes #20443, and adds support for generating dynamic filters for the left and right sides of a `SortMergeJoin`, in order to allow for range-based pruning of both sides of the join. Some consumers of the dynamic filter may even be able to seek/skip ahead on their inputs.
## What changes are included in this PR?
To allow `SortMergeJoin` to actually propagate dynamic filters down to scans and get things working end to end, it was necessary to fix the `handle_child_pushdown_result` implementations of a variety of nodes which were failing to clone and update themselves.
## Are these changes tested?
Yes.
## Are there any user-facing changes?
Explain will now show dynamic filters for `SortMergeJoin`, and for the scans that they consume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4168333851
π€ Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21267#issuecomment-4168260905)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
Comparing HEAD and stuhood.smj-dynamic-filter-creation
--------------------
Benchmark tpch_sf1.json
--------------------
βββββββββββββ³ββββββββββββββββββββββββββββββββββββ³ββββββββββββββββββββββββββββββββββββββ³ββββββββββββ
β Query β HEAD β stuhood.smj-dynamic-filter-creation β Change β
β‘ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ©
β QQuery 1 β 45.24 / 45.94 Β±1.02 / 47.94 ms β 45.10 / 45.82 Β±0.79 / 47.33 ms β no change β
β QQuery 2 β 62.30 / 62.70 Β±0.33 / 63.29 ms β 64.12 / 64.77 Β±0.67 / 65.97 ms β no change β
β QQuery 3 β 65.80 / 68.04 Β±1.62 / 70.81 ms β 67.30 / 69.42 Β±1.38 / 71.64 ms β no change β
β QQuery 4 β 49.71 / 50.23 Β±0.49 / 51.04 ms β 48.98 / 50.20 Β±0.79 / 51.14 ms β no change β
β QQuery 5 β 104.19 / 108.51 Β±2.61 / 111.40 ms β 110.09 / 111.50 Β±1.59 / 114.29 ms β no change β
β QQuery 6 β 17.14 / 17.42 Β±0.31 / 18.00 ms β 17.24 / 17.83 Β±0.69 / 19.16 ms β no change β
β QQuery 7 β 133.78 / 139.68 Β±4.06 / 145.86 ms β 133.69 / 135.14 Β±1.07 / 136.48 ms β no change β
β QQuery 8 β 124.05 / 128.64 Β±2.47 / 131.24 ms β 130.57 / 134.49 Β±2.93 / 138.52 ms β no change β
β QQuery 9 β 176.31 / 181.43 Β±4.78 / 189.10 ms β 178.07 / 181.78 Β±3.98 / 188.91 ms β no change β
β QQuery 10 β 85.60 / 87.71 Β±1.86 / 90.39 ms β 87.70 / 88.33 Β±0.60 / 89.16 ms β no change β
β QQuery 11 β 45.85 / 46.64 Β±0.85 / 48.25 ms β 45.81 / 46.33 Β±0.31 / 46.69 ms β no change β
β QQuery 12 β 37.66 / 38.72 Β±0.61 / 39.54 ms β 38.01 / 39.31 Β±0.75 / 40.34 ms β no change β
β QQuery 13 β 49.37 / 50.34 Β±0.97 / 51.89 ms β 49.05 / 50.92 Β±1.55 / 53.67 ms β no change β
β QQuery 14 β 29.16 / 29.45 Β±0.36 / 30.15 ms β 29.43 / 29.80 Β±0.24 / 30.09 ms β no change β
β QQuery 15 β 30.02 / 31.00 Β±0.53 / 31.57 ms β 30.56 / 30.93 Β±0.21 / 31.20 ms β no change β
β QQuery 16 β 21.59 / 22.18 Β±0.45 / 22.97 ms β 21.76 / 22.18 Β±0.32 / 22.65 ms β no change β
β QQuery 17 β 117.37 / 121.05 Β±2.63 / 123.98 ms β 117.44 / 121.00 Β±2.43 / 123.49 ms β no change β
β QQuery 18 β 146.26 / 148.03 Β±1.14 / 149.72 ms β 147.66 / 149.84 Β±1.86 / 152.46 ms β no change β
β QQuery 19 β 39.13 / 40.21 Β±0.79 / 41.36 ms β 39.61 / 40.22 Β±0.71 / 41.29 ms β no change β
β QQuery 20 β 57.61 / 60.29 Β±1.83 / 61.80 ms β 57.94 / 60.49 Β±1.34 / 61.56 ms β no change β
β QQuery 21 β 270.08 / 274.39 Β±2.81 / 277.53 ms β 266.98 / 270.57 Β±2.89 / 274.82 ms β no change β
β QQuery 22 β 37.79 / 38.22 Β±0.36 / 38.68 ms β 37.15 / 38.66 Β±1.02 / 39.78 ms β no change β
βββββββββββββ΄ββββββββββββββββββββββββββββββββββββ΄ββββββββββββββββββββββββββββββββββββββ΄ββββββββββββ
ββββββββββββββββββββββββββββββββββββββββββββββββββββββ³ββββββββββββ
β Benchmark Summary β β
β‘βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ©
β Total Time (HEAD) β 1790.82ms β
β Total Time (stuhood.smj-dynamic-filter-creation) β 1799.52ms β
β Average Time (HEAD) β 81.40ms β
β Average Time (stuhood.smj-dynamic-filter-creation) β 81.80ms β
β Queries Faster β 0 β
β Queries Slower β 0 β
β Queries with No Change β 22 β
β Queries with Failure β 0 β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββ΄ββββββββββββ
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch β base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 9.3s |
| Peak memory | 4.8 GiB |
| Avg memory | 4.0 GiB |
| CPU user | 73.8s |
| CPU sys | 4.5s |
| Disk read | 0 B |
| Disk write | 140.0 KiB |
**tpch β branch**
| Metric | Value |
|--------|-------|
| Wall time | 9.2s |
| Peak memory | 4.7 GiB |
| Avg memory | 3.9 GiB |
| CPU user | 74.3s |
| CPU sys | 4.5s |
| Disk read | 0 B |
| Disk write | 72.0 KiB |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4169636974
`β QQuery 37 β 287.33 / 292.20 Β±3.31 / 296.96 ms β 10.96 / 12.28 Β±1.81 / 15.75 ms β +23.80x faster β`
πππ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on code in PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#discussion_r3025836766
##########
datafusion/physical-plan/src/limit.rs:
##########
@@ -436,6 +467,29 @@ impl ExecutionPlan for LocalLimitExec {
fn cardinality_effect(&self) -> CardinalityEffect {
CardinalityEffect::LowerEqual
}
+
+ fn gather_filters_for_pushdown(
+ &self,
+ _phase: FilterPushdownPhase,
+ parent_filters: Vec<Arc<dyn PhysicalExpr>>,
+ _config: &ConfigOptions,
+ ) -> Result<FilterDescription> {
+ FilterDescription::from_children(parent_filters, &self.children())
+ }
+
+ fn handle_child_pushdown_result(
+ &self,
+ _phase: FilterPushdownPhase,
+ child_pushdown_result: ChildPushdownResult,
+ _config: &ConfigOptions,
+ ) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ result.updated_node =
+ Some(Arc::new(LocalLimitExec::new(updated_child, self.fetch)) as _);
Review Comment:
Same here
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -609,8 +655,14 @@ impl ExecutionPlan for FilterExec {
child_pushdown_result: ChildPushdownResult,
_config: &ConfigOptions,
) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
- if phase != FilterPushdownPhase::Pre {
- return Ok(FilterPushdownPropagation::if_all(child_pushdown_result));
+ if !matches!(phase, FilterPushdownPhase::Pre) {
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ let mut new_self = self.clone();
+ new_self.input = updated_child;
+ result.updated_node = Some(Arc::new(new_self) as _);
+ }
+ return Ok(result);
Review Comment:
Good catch! This is definitely a footgun. Any thoughts on how we can make the API less error prone? It would also be nice to put this into its own PR so we can fast track it.
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -433,7 +433,13 @@ impl ExecutionPlan for ProjectionExec {
child_pushdown_result: ChildPushdownResult,
_config: &ConfigOptions,
) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
- Ok(FilterPushdownPropagation::if_all(child_pushdown_result))
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ let mut new_self = self.clone();
+ new_self.input = updated_child;
+ result.updated_node = Some(Arc::new(new_self) as _);
+ }
+ Ok(result)
Review Comment:
ππ»
##########
datafusion/physical-plan/src/filter_pushdown.rs:
##########
@@ -444,13 +444,15 @@ impl ChildFilterDescription {
})
}
- /// Mark all parent filters as unsupported for this child.
+ /// Create a child filter description where all parent filters are marked as unsupported,
+ /// and no self filters are pushed down.
pub fn all_unsupported(parent_filters: &[Arc<dyn PhysicalExpr>]) -> Self {
+ let parent_filters = parent_filters
+ .iter()
+ .map(|f| PushedDownPredicate::unsupported(Arc::clone(f)))
+ .collect();
Self {
- parent_filters: parent_filters
- .iter()
- .map(|f| PushedDownPredicate::unsupported(Arc::clone(f)))
- .collect(),
+ parent_filters,
Review Comment:
ππ»
##########
datafusion/physical-plan/src/limit.rs:
##########
@@ -251,6 +256,32 @@ impl ExecutionPlan for GlobalLimitExec {
fn supports_limit_pushdown(&self) -> bool {
true
}
+
+ fn gather_filters_for_pushdown(
+ &self,
+ _phase: FilterPushdownPhase,
+ parent_filters: Vec<Arc<dyn PhysicalExpr>>,
+ _config: &ConfigOptions,
+ ) -> Result<FilterDescription> {
+ FilterDescription::from_children(parent_filters, &self.children())
+ }
+
+ fn handle_child_pushdown_result(
+ &self,
+ _phase: FilterPushdownPhase,
+ child_pushdown_result: ChildPushdownResult,
+ _config: &ConfigOptions,
+ ) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ result.updated_node = Some(Arc::new(GlobalLimitExec::new(
Review Comment:
```suggestion
result.updated_node = Some(Arc::new(Self::new(
```
?
##########
datafusion/physical-plan/src/coalesce_batches.rs:
##########
@@ -277,7 +277,13 @@ impl ExecutionPlan for CoalesceBatchesExec {
child_pushdown_result: ChildPushdownResult,
_config: &ConfigOptions,
) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
- Ok(FilterPushdownPropagation::if_all(child_pushdown_result))
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ let mut new_self = self.clone();
+ new_self.input = updated_child;
+ result.updated_node = Some(Arc::new(new_self) as _);
+ }
+ Ok(result)
Review Comment:
ππ»
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -1430,6 +1431,21 @@ impl ExecutionPlan for SortExec {
Ok(FilterDescription::new().with_child(child))
}
+
+ fn handle_child_pushdown_result(
+ &self,
+ _phase: FilterPushdownPhase,
+ child_pushdown_result: ChildPushdownResult,
+ _config: &datafusion_common::config::ConfigOptions,
+ ) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ let mut new_self = self.cloned();
+ new_self.input = updated_child;
+ result.updated_node = Some(Arc::new(new_self) as _);
+ }
+ Ok(result)
+ }
Review Comment:
Really need to eliminate this foot gun π¦Άπ»
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -1201,7 +1201,13 @@ impl ExecutionPlan for RepartitionExec {
child_pushdown_result: ChildPushdownResult,
_config: &ConfigOptions,
) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
- Ok(FilterPushdownPropagation::if_all(child_pushdown_result))
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ let mut new_self = self.clone();
+ new_self.input = updated_child;
+ result.updated_node = Some(Arc::new(new_self) as _);
+ }
+ Ok(result)
}
Review Comment:
ππ»
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4168274564
π€ Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21267#issuecomment-4168260905)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4168260905-641-j6htv 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing stuhood.smj-dynamic-filter-creation (155f7896ff2fe1c6093ea20f341b256ae1793339) to ccaf802 (merge-base) [diff](https://github.com/apache/datafusion/compare/ccaf8022da368052d8a1d910c28ccc8af8422e03..155f7896ff2fe1c6093ea20f341b256ae1793339) using: tpch
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4168260905
run benchmark tpch tpcds
```
env:
PREFER_HASH_JOIN: false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "stuhood (via GitHub)" <gi...@apache.org>.
stuhood commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4159901962
Supersedes #20455.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "stuhood (via GitHub)" <gi...@apache.org>.
stuhood commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4187622812
> Thank you for working on this. Can we split out the fixes for the other nodes into it's own PR that we can fast track (and maybe discuss any API improvements in)?
I will do this! But I will be on vacation for the next two weeks: will leave it in draft until I've applied your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "stuhood (via GitHub)" <gi...@apache.org>.
stuhood commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4805005398
We are going to be focused on partitioning (rather than sorting) for the near term, so I'm going to close this one for now. Sorry for the noise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4168369902
π€ Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21267#issuecomment-4168260905)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
Comparing HEAD and stuhood.smj-dynamic-filter-creation
--------------------
Benchmark tpcds_sf1.json
--------------------
βββββββββββββ³βββββββββββββββββββββββββββββββββββββββββ³βββββββββββββββββββββββββββββββββββββββββ³βββββββββββββββββ
β Query β HEAD β stuhood.smj-dynamic-filter-creation β Change β
β‘βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ©
β QQuery 1 β 52.30 / 52.86 Β±0.77 / 54.35 ms β 29.86 / 30.72 Β±0.69 / 31.91 ms β +1.72x faster β
β QQuery 2 β 146.72 / 147.55 Β±0.59 / 148.41 ms β 148.30 / 148.99 Β±0.60 / 150.08 ms β no change β
β QQuery 3 β 167.63 / 170.83 Β±2.57 / 175.17 ms β 171.67 / 173.94 Β±1.42 / 175.80 ms β no change β
β QQuery 4 β 1669.59 / 1749.08 Β±43.27 / 1798.33 ms β 1684.94 / 1743.79 Β±33.36 / 1780.29 ms β no change β
β QQuery 5 β 276.39 / 288.08 Β±7.60 / 300.18 ms β 285.69 / 290.85 Β±5.03 / 300.45 ms β no change β
β QQuery 6 β 245.14 / 247.05 Β±2.05 / 250.57 ms β 244.27 / 246.85 Β±1.91 / 249.38 ms β no change β
β QQuery 7 β 385.35 / 392.04 Β±5.60 / 399.55 ms β 393.30 / 395.54 Β±1.68 / 397.58 ms β no change β
β QQuery 8 β 189.51 / 191.63 Β±2.11 / 195.06 ms β 183.98 / 191.84 Β±4.79 / 198.75 ms β no change β
β QQuery 9 β 102.51 / 109.43 Β±4.76 / 116.03 ms β 102.14 / 106.07 Β±3.41 / 110.93 ms β no change β
β QQuery 10 β 256.32 / 258.92 Β±2.09 / 262.20 ms β 257.86 / 262.72 Β±3.26 / 266.57 ms β no change β
β QQuery 11 β 867.22 / 880.59 Β±9.92 / 894.43 ms β 865.49 / 884.39 Β±10.02 / 894.22 ms β no change β
β QQuery 12 β 53.30 / 54.20 Β±0.60 / 54.85 ms β 55.60 / 56.17 Β±0.78 / 57.70 ms β no change β
β QQuery 13 β 402.13 / 404.82 Β±1.93 / 406.97 ms β 403.70 / 405.61 Β±1.83 / 408.94 ms β no change β
β QQuery 14 β 2100.81 / 2123.33 Β±20.56 / 2161.67 ms β 2137.00 / 2144.23 Β±5.79 / 2150.69 ms β no change β
β QQuery 15 β 92.24 / 94.52 Β±1.77 / 96.39 ms β 94.12 / 95.35 Β±1.13 / 97.18 ms β no change β
β QQuery 16 β 159.49 / 160.59 Β±0.95 / 162.22 ms β 161.00 / 164.12 Β±1.96 / 166.83 ms β no change β
β QQuery 17 β 378.81 / 385.12 Β±5.15 / 391.61 ms β 382.49 / 388.50 Β±3.64 / 393.26 ms β no change β
β QQuery 18 β 292.96 / 297.38 Β±3.38 / 301.61 ms β 290.14 / 302.41 Β±6.41 / 307.18 ms β no change β
β QQuery 19 β 241.22 / 246.65 Β±3.42 / 251.28 ms β 240.88 / 246.87 Β±4.43 / 252.24 ms β no change β
β QQuery 20 β 90.57 / 92.42 Β±1.45 / 94.79 ms β 92.70 / 94.03 Β±1.51 / 96.85 ms β no change β
β QQuery 21 β 857.71 / 862.36 Β±2.94 / 865.60 ms β 844.21 / 859.13 Β±9.53 / 870.05 ms β no change β
β QQuery 22 β 400.27 / 415.16 Β±8.13 / 425.08 ms β 404.59 / 411.25 Β±6.11 / 420.39 ms β no change β
β QQuery 23 β 1145.00 / 1160.85 Β±11.42 / 1177.24 ms β 1145.09 / 1176.14 Β±25.03 / 1206.52 ms β no change β
β QQuery 24 β 905.73 / 918.29 Β±7.32 / 927.96 ms β 872.92 / 877.24 Β±3.23 / 881.07 ms β no change β
β QQuery 25 β 444.80 / 446.63 Β±1.19 / 447.71 ms β 437.66 / 441.71 Β±2.21 / 443.88 ms β no change β
β QQuery 26 β 205.37 / 211.81 Β±4.76 / 218.80 ms β 206.06 / 210.09 Β±2.73 / 213.72 ms β no change β
β QQuery 27 β 386.41 / 389.97 Β±2.77 / 394.66 ms β 375.16 / 382.78 Β±5.30 / 389.69 ms β no change β
β QQuery 28 β 150.57 / 151.40 Β±0.60 / 152.39 ms β 150.29 / 152.08 Β±1.33 / 154.37 ms β no change β
β QQuery 29 β 381.41 / 385.57 Β±3.99 / 392.12 ms β 376.58 / 381.68 Β±2.82 / 384.14 ms β no change β
β QQuery 30 β 54.89 / 56.24 Β±1.10 / 57.47 ms β 57.90 / 58.56 Β±0.62 / 59.49 ms β no change β
β QQuery 31 β 648.63 / 657.42 Β±4.82 / 663.04 ms β 653.80 / 657.28 Β±4.38 / 665.86 ms β no change β
β QQuery 32 β 148.70 / 149.87 Β±0.83 / 150.86 ms β 149.57 / 150.46 Β±1.03 / 152.38 ms β no change β
β QQuery 33 β 216.20 / 223.33 Β±3.79 / 226.55 ms β 219.48 / 222.30 Β±2.01 / 225.03 ms β no change β
β QQuery 34 β 190.39 / 194.13 Β±3.15 / 199.60 ms β 187.65 / 188.48 Β±0.90 / 190.12 ms β no change β
β QQuery 35 β 246.71 / 248.31 Β±1.60 / 251.34 ms β 248.66 / 250.87 Β±1.42 / 252.67 ms β no change β
β QQuery 36 β 281.40 / 283.28 Β±1.66 / 285.42 ms β 284.38 / 286.47 Β±2.23 / 289.59 ms β no change β
β QQuery 37 β 287.33 / 292.20 Β±3.31 / 296.96 ms β 10.96 / 12.28 Β±1.81 / 15.75 ms β +23.80x faster β
β QQuery 38 β 200.37 / 202.60 Β±2.12 / 206.57 ms β 202.99 / 204.71 Β±1.53 / 207.40 ms β no change β
β QQuery 39 β 3963.92 / 3971.78 Β±7.67 / 3984.45 ms β 3938.72 / 3979.32 Β±22.21 / 3997.13 ms β no change β
β QQuery 40 β 172.88 / 178.32 Β±5.00 / 184.38 ms β 172.99 / 175.49 Β±3.49 / 182.38 ms β no change β
β QQuery 41 β 14.75 / 16.15 Β±1.04 / 17.37 ms β 14.66 / 15.37 Β±0.96 / 17.25 ms β no change β
β QQuery 42 β 170.95 / 172.68 Β±1.49 / 174.49 ms β 170.45 / 173.15 Β±1.74 / 175.65 ms β no change β
β QQuery 43 β 151.22 / 154.10 Β±2.50 / 157.47 ms β 156.29 / 161.02 Β±3.57 / 166.18 ms β no change β
β QQuery 44 β 13.34 / 14.68 Β±0.87 / 15.60 ms β 11.03 / 12.91 Β±1.89 / 16.35 ms β +1.14x faster β
β QQuery 45 β 69.36 / 70.59 Β±1.00 / 71.71 ms β 68.61 / 70.40 Β±2.22 / 74.67 ms β no change β
β QQuery 46 β 354.69 / 359.38 Β±2.66 / 362.34 ms β 344.95 / 349.47 Β±3.66 / 355.19 ms β no change β
β QQuery 47 β 798.32 / 804.81 Β±7.63 / 819.42 ms β 797.05 / 804.50 Β±6.06 / 812.81 ms β no change β
β QQuery 48 β 289.70 / 293.37 Β±2.19 / 295.61 ms β 290.12 / 293.16 Β±2.33 / 296.62 ms β no change β
β QQuery 49 β 264.82 / 266.42 Β±1.08 / 267.75 ms β 265.41 / 270.01 Β±4.91 / 278.67 ms β no change β
β QQuery 50 β 230.03 / 234.23 Β±3.36 / 238.44 ms β 228.74 / 230.81 Β±1.96 / 234.06 ms β no change β
β QQuery 51 β 235.96 / 239.67 Β±3.66 / 246.64 ms β 236.95 / 238.24 Β±1.36 / 240.12 ms β no change β
β QQuery 52 β 170.18 / 173.06 Β±1.93 / 175.39 ms β 171.05 / 173.25 Β±1.67 / 175.80 ms β no change β
β QQuery 53 β 175.78 / 180.14 Β±2.59 / 182.56 ms β 177.36 / 179.79 Β±2.17 / 182.34 ms β no change β
β QQuery 54 β 267.43 / 271.11 Β±2.63 / 274.82 ms β 270.85 / 277.97 Β±5.32 / 284.38 ms β no change β
β QQuery 55 β 169.67 / 173.29 Β±4.47 / 182.04 ms β 173.20 / 175.25 Β±1.54 / 177.30 ms β no change β
β QQuery 56 β 216.26 / 223.21 Β±3.90 / 226.93 ms β 223.08 / 225.90 Β±1.95 / 229.04 ms β no change β
β QQuery 57 β 373.94 / 379.73 Β±3.77 / 385.31 ms β 376.59 / 381.52 Β±3.29 / 385.70 ms β no change β
β QQuery 58 β 413.34 / 417.38 Β±3.81 / 423.45 ms β 405.88 / 416.41 Β±6.66 / 425.05 ms β no change β
β QQuery 59 β 304.83 / 308.81 Β±3.15 / 313.68 ms β 305.25 / 309.22 Β±2.52 / 312.60 ms β no change β
β QQuery 60 β 215.35 / 221.04 Β±3.16 / 224.55 ms β 222.29 / 225.10 Β±3.08 / 230.62 ms β no change β
β QQuery 61 β 288.23 / 291.01 Β±3.91 / 298.73 ms β 281.14 / 283.87 Β±1.75 / 286.11 ms β no change β
β QQuery 62 β 86.22 / 87.65 Β±1.23 / 89.38 ms β 86.29 / 86.93 Β±0.40 / 87.41 ms β no change β
β QQuery 63 β 176.33 / 179.47 Β±3.03 / 183.44 ms β 181.00 / 183.81 Β±1.74 / 185.30 ms β no change β
β QQuery 64 β 1508.37 / 1526.06 Β±12.22 / 1544.55 ms β 1530.30 / 1537.32 Β±4.81 / 1542.69 ms β no change β
β QQuery 65 β 346.99 / 352.81 Β±3.72 / 356.86 ms β 344.33 / 354.42 Β±7.75 / 364.17 ms β no change β
β QQuery 66 β 296.41 / 312.35 Β±11.30 / 328.03 ms β 302.15 / 311.15 Β±7.42 / 319.37 ms β no change β
β QQuery 67 β 278.73 / 284.00 Β±4.29 / 290.61 ms β 279.25 / 281.76 Β±1.28 / 282.69 ms β no change β
β QQuery 68 β 414.47 / 421.74 Β±4.87 / 427.57 ms β 409.10 / 411.40 Β±1.89 / 414.80 ms β no change β
β QQuery 69 β 254.54 / 259.08 Β±4.43 / 265.29 ms β 253.63 / 256.70 Β±2.79 / 260.12 ms β no change β
β QQuery 70 β 452.21 / 459.33 Β±3.83 / 462.87 ms β 454.12 / 459.87 Β±4.25 / 466.82 ms β no change β
β QQuery 71 β 214.94 / 218.48 Β±4.48 / 226.84 ms β 218.91 / 221.71 Β±2.53 / 226.38 ms β no change β
β QQuery 72 β 8619.56 / 9101.83 Β±277.75 / 9421.56 ms β 8621.28 / 9094.63 Β±240.55 / 9284.71 ms β no change β
β QQuery 73 β 189.07 / 204.12 Β±21.49 / 246.76 ms β 185.65 / 189.01 Β±3.17 / 193.93 ms β +1.08x faster β
β QQuery 74 β 618.09 / 620.74 Β±2.29 / 624.34 ms β 609.13 / 618.68 Β±6.02 / 626.22 ms β no change β
β QQuery 75 β 532.86 / 547.75 Β±8.77 / 557.23 ms β 535.74 / 543.84 Β±5.83 / 553.89 ms β no change β
β QQuery 76 β 138.86 / 140.84 Β±1.87 / 144.01 ms β 136.87 / 138.29 Β±1.98 / 142.19 ms β no change β
β QQuery 77 β 286.62 / 288.84 Β±1.50 / 290.22 ms β 281.23 / 284.46 Β±3.20 / 289.54 ms β no change β
β QQuery 78 β 592.26 / 604.65 Β±8.91 / 619.39 ms β 579.50 / 591.67 Β±10.81 / 611.48 ms β no change β
β QQuery 79 β 360.15 / 364.32 Β±2.53 / 367.26 ms β 349.13 / 352.61 Β±2.50 / 355.19 ms β no change β
β QQuery 80 β 475.17 / 490.82 Β±9.00 / 499.56 ms β 459.98 / 468.38 Β±5.21 / 476.29 ms β no change β
β QQuery 81 β 59.80 / 63.34 Β±3.42 / 67.56 ms β 62.14 / 67.43 Β±4.90 / 75.16 ms β 1.06x slower β
β QQuery 82 β 335.42 / 341.60 Β±5.14 / 350.78 ms β 333.41 / 337.35 Β±2.82 / 342.02 ms β no change β
β QQuery 83 β 69.31 / 71.76 Β±2.15 / 74.98 ms β 68.38 / 70.15 Β±1.71 / 72.60 ms β no change β
β QQuery 84 β 70.76 / 71.45 Β±0.97 / 73.32 ms β 71.67 / 72.77 Β±0.89 / 74.00 ms β no change β
β QQuery 85 β 183.55 / 189.02 Β±4.64 / 196.45 ms β 183.80 / 188.31 Β±2.62 / 191.88 ms β no change β
β QQuery 86 β 46.57 / 47.36 Β±0.67 / 48.16 ms β 47.40 / 49.69 Β±1.17 / 50.47 ms β no change β
β QQuery 87 β 204.21 / 205.93 Β±1.42 / 208.43 ms β 206.06 / 207.45 Β±1.80 / 210.91 ms β no change β
β QQuery 88 β 317.47 / 323.80 Β±5.87 / 334.86 ms β 321.75 / 329.78 Β±4.19 / 333.88 ms β no change β
β QQuery 89 β 182.43 / 188.63 Β±5.82 / 198.75 ms β 180.72 / 186.77 Β±4.08 / 192.74 ms β no change β
β QQuery 90 β 42.68 / 43.78 Β±1.03 / 45.63 ms β 43.26 / 44.27 Β±1.13 / 46.48 ms β no change β
β QQuery 91 β 72.08 / 73.66 Β±1.27 / 75.90 ms β 73.94 / 76.62 Β±2.18 / 80.30 ms β no change β
β QQuery 92 β 86.00 / 86.56 Β±0.39 / 87.08 ms β 89.56 / 90.86 Β±1.21 / 92.97 ms β no change β
β QQuery 93 β 394.60 / 397.14 Β±1.46 / 399.10 ms β 399.36 / 404.66 Β±4.51 / 411.35 ms β no change β
β QQuery 94 β 96.35 / 98.30 Β±1.54 / 100.10 ms β 97.18 / 98.68 Β±1.11 / 100.22 ms β no change β
β QQuery 95 β 178.04 / 179.93 Β±1.94 / 183.22 ms β 179.47 / 182.55 Β±2.83 / 187.79 ms β no change β
β QQuery 96 β 135.38 / 136.88 Β±1.50 / 139.17 ms β 134.64 / 137.12 Β±1.51 / 139.39 ms β no change β
β QQuery 97 β 209.73 / 211.05 Β±1.69 / 214.31 ms β 209.72 / 212.26 Β±2.42 / 216.60 ms β no change β
β QQuery 98 β 196.75 / 199.51 Β±3.00 / 203.79 ms β 197.16 / 201.28 Β±2.98 / 205.35 ms β no change β
β QQuery 99 β 217.78 / 220.83 Β±1.87 / 223.67 ms β 221.42 / 224.24 Β±2.74 / 228.23 ms β no change β
βββββββββββββ΄βββββββββββββββββββββββββββββββββββββββββ΄βββββββββββββββββββββββββββββββββββββββββ΄βββββββββββββββββ
ββββββββββββββββββββββββββββββββββββββββββββββββββββββ³βββββββββββββ
β Benchmark Summary β β
β‘ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ©
β Total Time (HEAD) β 44626.87ms β
β Total Time (stuhood.smj-dynamic-filter-creation) β 44287.52ms β
β Average Time (HEAD) β 450.78ms β
β Average Time (stuhood.smj-dynamic-filter-creation) β 447.35ms β
β Queries Faster β 4 β
β Queries Slower β 1 β
β Queries with No Change β 94 β
β Queries with Failure β 0 β
ββββββββββββββββββββββββββββββββββββββββββββββββββββββ΄βββββββββββββ
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds β base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 223.5s |
| Peak memory | 27.8 GiB |
| Avg memory | 6.3 GiB |
| CPU user | 909.8s |
| CPU sys | 92.9s |
| Disk read | 0 B |
| Disk write | 638.2 MiB |
**tpcds β branch**
| Metric | Value |
|--------|-------|
| Wall time | 221.8s |
| Peak memory | 27.6 GiB |
| Avg memory | 6.1 GiB |
| CPU user | 905.2s |
| CPU sys | 92.7s |
| Disk read | 0 B |
| Disk write | 152.0 KiB |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#issuecomment-4168275332
π€ Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21267#issuecomment-4168260905)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4168260905-642-t9w6j 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing stuhood.smj-dynamic-filter-creation (155f7896ff2fe1c6093ea20f341b256ae1793339) to ccaf802 (merge-base) [diff](https://github.com/apache/datafusion/compare/ccaf8022da368052d8a1d910c28ccc8af8422e03..155f7896ff2fe1c6093ea20f341b256ae1793339) using: tpcds
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on code in PR #21267:
URL: https://github.com/apache/datafusion/pull/21267#discussion_r3281635155
##########
datafusion/physical-plan/src/coalesce_batches.rs:
##########
@@ -277,7 +277,13 @@ impl ExecutionPlan for CoalesceBatchesExec {
child_pushdown_result: ChildPushdownResult,
_config: &ConfigOptions,
) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
- Ok(FilterPushdownPropagation::if_all(child_pushdown_result))
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ let mut new_self = self.clone();
+ new_self.input = updated_child;
+ result.updated_node = Some(Arc::new(new_self) as _);
+ }
+ Ok(result)
Review Comment:
@stuhood looking at this again I'm not sure this is needed / there is a real bug. Do you have a regression test that fails?
`FilterPushdownPropagation::if_all` always sets `updated_node: None`:
https://github.com/apache/datafusion/blob/ad6a507beb0d9bcdd7c791524ba3af32be60c143/datafusion/physical-plan/src/filter_pushdown.rs#L238-L248
And then in the optimizer rule:
https://github.com/apache/datafusion/blob/ad6a507beb0d9bcdd7c791524ba3af32be60c143/datafusion/physical-optimizer/src/filter_pushdown.rs#L567-L568
https://github.com/apache/datafusion/blob/ad6a507beb0d9bcdd7c791524ba3af32be60c143/datafusion/physical-optimizer/src/filter_pushdown.rs#L591-L595
##########
datafusion/physical-plan/src/coalesce_batches.rs:
##########
@@ -277,7 +277,13 @@ impl ExecutionPlan for CoalesceBatchesExec {
child_pushdown_result: ChildPushdownResult,
_config: &ConfigOptions,
) -> Result<FilterPushdownPropagation<Arc<dyn ExecutionPlan>>> {
- Ok(FilterPushdownPropagation::if_all(child_pushdown_result))
+ let mut result = FilterPushdownPropagation::if_all(child_pushdown_result);
+ if let Some(updated_child) = result.updated_node {
+ let mut new_self = self.clone();
+ new_self.input = updated_child;
+ result.updated_node = Some(Arc::new(new_self) as _);
+ }
+ Ok(result)
Review Comment:
So basically if any children have been updated we update the parent. Let me know if I'm missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Create dynamic filters in SortMergeJoin [datafusion]
Posted by "stuhood (via GitHub)" <gi...@apache.org>.
stuhood closed pull request #21267: feat: Create dynamic filters in SortMergeJoin
URL: https://github.com/apache/datafusion/pull/21267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org