You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/08/21 03:43:32 UTC

[GitHub] [pulsar] codecov-commenter commented on pull request #20983: [fix][broker] Fix compaction subscription delete by inactive subscription check.

codecov-commenter commented on PR #20983:
URL: https://github.com/apache/pulsar/pull/20983#issuecomment-1685592247

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#20983](https://app.codecov.io/gh/apache/pulsar/pull/20983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (128ff3f) into [master](https://app.codecov.io/gh/apache/pulsar/commit/98628845aa94b416b0c3711b5a15819ade549c57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9862884) will **increase** coverage by `38.79%`.
   > Report is 25 commits behind head on master.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/20983/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/20983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #20983       +/-   ##
   =============================================
   + Coverage     33.53%   72.32%   +38.79%     
   - Complexity    12174    32210    +20036     
   =============================================
     Files          1621     1863      +242     
     Lines        126919   140635    +13716     
     Branches      13851    15725     +1874     
   =============================================
   + Hits          42561   101717    +59156     
   + Misses        78745    30811    -47934     
   - Partials       5613     8107     +2494     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/20983/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/20983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.19% <66.66%> (-0.09%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/20983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.09% <83.33%> (+40.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files Changed](https://app.codecov.io/gh/apache/pulsar/pull/20983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...rization/MultiRolesTokenAuthorizationProvider.java](https://app.codecov.io/gh/apache/pulsar/pull/20983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvYXV0aG9yaXphdGlvbi9NdWx0aVJvbGVzVG9rZW5BdXRob3JpemF0aW9uUHJvdmlkZXIuamF2YQ==) | `60.43% <40.00%> (+60.43%)` | :arrow_up: |
   | [...sar/broker/service/persistent/PersistentTopic.java](https://app.codecov.io/gh/apache/pulsar/pull/20983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFRvcGljLmphdmE=) | `79.87% <100.00%> (+26.50%)` | :arrow_up: |
   | [...ava/org/apache/pulsar/utils/StatsOutputStream.java](https://app.codecov.io/gh/apache/pulsar/pull/20983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3V0aWxzL1N0YXRzT3V0cHV0U3RyZWFtLmphdmE=) | `100.00% <100.00%> (+29.09%)` | :arrow_up: |
   
   ... and [1491 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20983/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org