[GitHub] [maven-assembly-plugin] michael-o commented on a diff in pull request #54: [MASSEMBLY-954] Update plugin to Maven 3.2.5

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #54:
URL: https://github.com/apache/maven-assembly-plugin/pull/54#discussion_r858550618


##########
pom.xml:
##########
@@ -66,9 +66,11 @@ under the License.
   <properties>
     <javaVersion>7</javaVersion>
     <mdoVersion>2.1.0</mdoVersion>
-    <mavenArchiverVersion>3.5.1</mavenArchiverVersion>
-    <mavenFilteringVersion>3.2.0</mavenFilteringVersion>
-    <mavenVersion>3.0</mavenVersion>
+    <mavenVersion>3.2.5</mavenVersion>
+    <sisuVersion>0.3.5</sisuVersion>
+    <slf4jVersion>1.7.5</slf4jVersion>

Review Comment:
   1.7.5?



##########
src/main/java/org/apache/maven/plugins/assembly/internal/ComponentSupport.java:
##########
@@ -19,16 +19,18 @@
  * under the License.
  */
 
-import org.codehaus.plexus.archiver.zip.ZipUnArchiver;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
- * @author jdcasey
- *
- *          //todo delete this class once the plexus maven plugin can merge a generated components.xml with an
- *          existing one.
+ * Support for components.
  */
-class SarUnArchiver
-    extends ZipUnArchiver
+public abstract class ComponentSupport

Review Comment:
   I would deprecate this class right away if it will only contain logger injection.



##########
src/main/java/org/apache/maven/plugins/assembly/utils/AssemblyFormatUtils.java:
##########
@@ -383,13 +374,12 @@ else if ( "..".equals( part ) )
      * <li>environment variables.</li>
      * </ol>
      */
-    public static String evaluateFileNameMapping( final String expression, @Nonnull final Artifact artifact,
-                                                  @Nullable final MavenProject mainProject,
-                                                  @Nullable final Artifact moduleArtifact,
-                                                  @Nonnull final AssemblerConfigurationSource configSource,
+    public static String evaluateFileNameMapping( final String expression, final Artifact artifact,
+                                                  /* nullable */ final MavenProject mainProject,

Review Comment:
   Shouldn't this be part of the Javadoc?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org