[GitHub] [arrow] AlenkaF commented on pull request #13311: ARROW-16340: [Python] Move all Python related code into PyArrow

[GitBox <gi...@apache.org>]

AlenkaF commented on PR #13311:
URL: https://github.com/apache/arrow/pull/13311#issuecomment-1171927470

   I would like to put this PR ready for review.
   
   There are still two CI failures I am investigating (see ⬇️ ) plus `test_cython_api()` from `test_cython.py` is broke, so I am researching it at the moment. But I think this shouldn't block this PR to get initial reviews 🙏  @kou @pitrou @kszucs @jorisvandenbossche 
   
   - `Could NOT find Python3 (missing: Python3_NumPy_INCLUDE_DIRS NumPy)`
   I have seen this error in some other failing builds and am not sure if it is connected to this PR or not.
   ```
     CMake Error at /opt/conda/envs/arrow/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
       Could NOT find Python3 (missing: Python3_NumPy_INCLUDE_DIRS NumPy) (found
       suitable version "3.9.13", minimum required is "3.7")
     Call Stack (most recent call first):
       /opt/conda/envs/arrow/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
       /opt/conda/envs/arrow/share/cmake-3.23/Modules/FindPython/Support.cmake:3192 (find_package_handle_standard_args)
       /opt/conda/envs/arrow/share/cmake-3.23/Modules/FindPython3.cmake:490 (include)
       /arrow/python/cmake_modules/FindPython3Alt.cmake:56 (find_package)
       CMakeLists.txt:64 (find_package)
   ```
   - `fatal error: arrow/flight/Flight.pb.h: No such file or directory`
   This error is for sure connected to this PR. I have bumped into it locally for python flight build but it dissapeared after I continued making changes to the code.
   
   ```
     In file included from /arrow/cpp/src/arrow/flight/serialization_internal.h:22,
                      from /arrow/python/pyarrow/src_arrow/flight.cc:21:
     /arrow/cpp/src/arrow/flight/protocol_internal.h:23:10: fatal error: arrow/flight/Flight.pb.h: No such file or directory
        23 | #include "arrow/flight/Flight.pb.h"  // IWYU pragma: export
           |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
     compilation terminated.
     make[2]: *** [CMakeFiles/arrow_python_flight_objlib.dir/build.make:76: CMakeFiles/arrow_python_flight_objlib.dir/flight.cc.o] Error 1
     make[1]: *** [CMakeFiles/Makefile2:255: CMakeFiles/arrow_python_flight_objlib.dir/all] Error 2
     make: *** [Makefile:136: all] Error 2
     error: command '/opt/conda/envs/arrow/bin/make' failed with exit code 2
     error: subprocess-exited-with-error
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org