You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jason Chaffee (JIRA)" <ji...@codehaus.org> on 2006/05/20 05:17:41 UTC

[jira] Created: (MSUREFIRE-117) Surefire doesn't work if testng is in the classpath and a suitexml isn't being used

Surefire doesn't work if testng is in the classpath and a suitexml isn't being used
-----------------------------------------------------------------------------------

         Key: MSUREFIRE-117
         URL: http://jira.codehaus.org/browse/MSUREFIRE-117
     Project: Maven 2.x Surefire Plugin
        Type: Bug

    Versions: 2.2    
    Reporter: Jason Chaffee
 Attachments: patch.txt

Bascially, not tests will be run.  I was able to fix this in the latest surefire code, by changing this code in TestNGDirectoryTestSuite.java:


        try
        {
            Class junitClass = Class.forName( "junit.framework.Test" );
            xmlTest.setJUnit( testSet.getTestClass().isAssignableFrom( junitClass ) );
        }
        catch ( ClassNotFoundException e )
        {
        }

to this code:

        if ( !TestNGClassFinder.isTestNGClass( testSet.getTestClass(), annotationFinder ) )
        {
            xmlTest.setJUnit( true );
        }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (SUREFIRE-208) Surefire doesn't work if testng is in the classpath and a suitexml isn't being used

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated SUREFIRE-208:
----------------------------------

    Affects Version/s: 2.0 (2.2 plugin)

> Surefire doesn't work if testng is in the classpath and a suitexml isn't being used
> -----------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-208
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-208
>             Project: Maven Surefire
>          Issue Type: Bug
>    Affects Versions: 2.0 (2.2 plugin)
>            Reporter: Jason Chaffee
>         Assigned To: Brett Porter
>         Attachments: patch.txt
>
>
> Bascially, not tests will be run.  I was able to fix this in the latest surefire code, by changing this code in TestNGDirectoryTestSuite.java:
>         try
>         {
>             Class junitClass = Class.forName( "junit.framework.Test" );
>             xmlTest.setJUnit( testSet.getTestClass().isAssignableFrom( junitClass ) );
>         }
>         catch ( ClassNotFoundException e )
>         {
>         }
> to this code:
>         if ( !TestNGClassFinder.isTestNGClass( testSet.getTestClass(), annotationFinder ) )
>         {
>             xmlTest.setJUnit( true );
>         }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Moved: (SUREFIRE-208) Surefire doesn't work if testng is in the classpath and a suitexml isn't being used

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter moved MSUREFIRE-117 to SUREFIRE-208:
-------------------------------------------------

    Affects Version/s:     (was: 2.0 (2.2 plugin))
                  Key: SUREFIRE-208  (was: MSUREFIRE-117)
              Project: Maven Surefire  (was: Maven 2.x Surefire Plugin)

> Surefire doesn't work if testng is in the classpath and a suitexml isn't being used
> -----------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-208
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-208
>             Project: Maven Surefire
>          Issue Type: Bug
>            Reporter: Jason Chaffee
>         Assigned To: Brett Porter
>         Attachments: patch.txt
>
>
> Bascially, not tests will be run.  I was able to fix this in the latest surefire code, by changing this code in TestNGDirectoryTestSuite.java:
>         try
>         {
>             Class junitClass = Class.forName( "junit.framework.Test" );
>             xmlTest.setJUnit( testSet.getTestClass().isAssignableFrom( junitClass ) );
>         }
>         catch ( ClassNotFoundException e )
>         {
>         }
> to this code:
>         if ( !TestNGClassFinder.isTestNGClass( testSet.getTestClass(), annotationFinder ) )
>         {
>             xmlTest.setJUnit( true );
>         }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira