You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@httpd.apache.org by Jaco Kroon <ja...@uls.co.za> on 2012/01/05 21:28:08 UTC
[users@httpd] DAV patches - feature enhancement
Hi All,
I've recently started using mod_dav_acl[1] and mod_caldav[2] for
calendaring purposes. These modules works very well, however,
mod_dav_acl currently requires a patch to be applied to the apache core
code in order to expose some hooks from the DAV subsystem, as per the
README from mod_dav_acl:
-requires patches to Apache, mostly to mod_dav module, patch(es) included.
Patch contains strong ETag handling, usec timestamps to ETags
(libapr-patch),
conditional PUTs (fixed after 2.2.8) and some hooks to allow integration of
ACL handlings. Apply the patch to Apache sources and compile it before using
this module.
I believe the first part of that is no longer the case as the patch I'm
using now (attached) only touches httpd-2.2.8/modules/dav/fs/repos.c and
httpd-2.2.8/modules/dav/main/mod_dav.c.
The changes to repos is somewhat unclear for me but still seems to
affect ETag handling (I can probably live without this), the changes to
mod_dav.c seems to be there mostly to add the hooks and extra
functionality that mod_dav_acl requires, but for some reason cannot be
external to mod_dav.c (don't ask me why, I won't pretend to understand
half of the code bases in question)
I'm not sure if the approach being taken by the author of mod_dav_acl is
correct in terms of the patch being applied to httpd, if there is a
better way to approach the problem, or if there is a better place for
discussion please advise, I'd be happy to file bugs against either httpd
or mod_dav_acl, and quite possibly write some code, to get to the point
where I don't need to custom-patch either side to make this work, and
that they can both live in harmony and happy ever after.
I'm attaching the suggested patch, I hope this is in order. The patch
does apply cleanly to httpd-2.2.21, which I believe is currently the
newest "stable" version.
Kind Regards,
Jaco
[1] http://moddavacl.sourceforge.net/
[2] http://modcaldav.sourceforge.net/
[users@httpd] Re: DAV patches - feature enhancement
Posted by DW <xf...@hotmail.com>.
Jaco Kroon wrote:
> Hi,
>
> That is a very good question indeed. I would bet that cygwin is most
> likely your best option, look for a package called patch, and you will
> need to extract the patch first with gunzip. Once on the "cygwin
> terminal" (probably some variant of bash), cd into the base folder for
> you httpd source and execute this:
>
> $ gunzip < /path/to/the/patch | patch -p1
>
> This should apply the patch. If you'd like to check first that it will
> apply, use --dry-run as a secondary parameter for patch.
>
> There are probably other ways, but only being familiar with Linux I
> wouldn't be able to advise on those.
>
> Kind Regards,
> Jaco
Thanks for the info. Will try later and let you know how it goes.
---------------------------------------------------------------------
The official User-To-User support forum of the Apache HTTP Server Project.
See <URL:http://httpd.apache.org/userslist.html> for more info.
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
" from the digest: users-digest-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org
Re: [users@httpd] Re: DAV patches - feature enhancement
Posted by Jaco Kroon <ja...@uls.co.za>.
Hi,
That is a very good question indeed. I would bet that cygwin is most
likely your best option, look for a package called patch, and you will
need to extract the patch first with gunzip. Once on the "cygwin
terminal" (probably some variant of bash), cd into the base folder for
you httpd source and execute this:
$ gunzip < /path/to/the/patch | patch -p1
This should apply the patch. If you'd like to check first that it will
apply, use --dry-run as a secondary parameter for patch.
There are probably other ways, but only being familiar with Linux I
wouldn't be able to advise on those.
Kind Regards,
Jaco
On 06/01/12 04:55, DW wrote:
> How do you apply these patches on a Windows system?
>
> Thanks.
>
>
>
> Jaco Kroon wrote:
>> Hi All,
>>
>> I've recently started using mod_dav_acl[1] and mod_caldav[2] for
>> calendaring purposes. These modules works very well, however,
>> mod_dav_acl currently requires a patch to be applied to the apache core
>> code in order to expose some hooks from the DAV subsystem, as per the
>> README from mod_dav_acl:
>>
>> -requires patches to Apache, mostly to mod_dav module, patch(es) included.
>> Patch contains strong ETag handling, usec timestamps to ETags
>> (libapr-patch),
>> conditional PUTs (fixed after 2.2.8) and some hooks to allow integration of
>> ACL handlings. Apply the patch to Apache sources and compile it before
>> using
>> this module.
>>
>> I believe the first part of that is no longer the case as the patch I'm
>> using now (attached) only touches httpd-2.2.8/modules/dav/fs/repos.c and
>> httpd-2.2.8/modules/dav/main/mod_dav.c.
>>
>> The changes to repos is somewhat unclear for me but still seems to
>> affect ETag handling (I can probably live without this), the changes to
>> mod_dav.c seems to be there mostly to add the hooks and extra
>> functionality that mod_dav_acl requires, but for some reason cannot be
>> external to mod_dav.c (don't ask me why, I won't pretend to understand
>> half of the code bases in question)
>>
>> I'm not sure if the approach being taken by the author of mod_dav_acl is
>> correct in terms of the patch being applied to httpd, if there is a
>> better way to approach the problem, or if there is a better place for
>> discussion please advise, I'd be happy to file bugs against either httpd
>> or mod_dav_acl, and quite possibly write some code, to get to the point
>> where I don't need to custom-patch either side to make this work, and
>> that they can both live in harmony and happy ever after.
>>
>> I'm attaching the suggested patch, I hope this is in order. The patch
>> does apply cleanly to httpd-2.2.21, which I believe is currently the
>> newest "stable" version.
>>
>> Kind Regards,
>> Jaco
>>
>> [1] http://moddavacl.sourceforge.net/
>> [2] http://modcaldav.sourceforge.net/
>>
>>
>> ------------------------------------------------------------------------
>>
>>
>> ---------------------------------------------------------------------
>> The official User-To-User support forum of the Apache HTTP Server Project.
>> See<URL:http://httpd.apache.org/userslist.html> for more info.
>> To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
>> " from the digest: users-digest-unsubscribe@httpd.apache.org
>> For additional commands, e-mail: users-help@httpd.apache.org
>
> ---------------------------------------------------------------------
> The official User-To-User support forum of the Apache HTTP Server Project.
> See<URL:http://httpd.apache.org/userslist.html> for more info.
> To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
> " from the digest: users-digest-unsubscribe@httpd.apache.org
> For additional commands, e-mail: users-help@httpd.apache.org
>
---------------------------------------------------------------------
The official User-To-User support forum of the Apache HTTP Server Project.
See <URL:http://httpd.apache.org/userslist.html> for more info.
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
" from the digest: users-digest-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org
[users@httpd] Re: DAV patches - feature enhancement
Posted by DW <xf...@hotmail.com>.
How do you apply these patches on a Windows system?
Thanks.
Jaco Kroon wrote:
> Hi All,
>
> I've recently started using mod_dav_acl[1] and mod_caldav[2] for
> calendaring purposes. These modules works very well, however,
> mod_dav_acl currently requires a patch to be applied to the apache core
> code in order to expose some hooks from the DAV subsystem, as per the
> README from mod_dav_acl:
>
> -requires patches to Apache, mostly to mod_dav module, patch(es) included.
> Patch contains strong ETag handling, usec timestamps to ETags
> (libapr-patch),
> conditional PUTs (fixed after 2.2.8) and some hooks to allow integration of
> ACL handlings. Apply the patch to Apache sources and compile it before
> using
> this module.
>
> I believe the first part of that is no longer the case as the patch I'm
> using now (attached) only touches httpd-2.2.8/modules/dav/fs/repos.c and
> httpd-2.2.8/modules/dav/main/mod_dav.c.
>
> The changes to repos is somewhat unclear for me but still seems to
> affect ETag handling (I can probably live without this), the changes to
> mod_dav.c seems to be there mostly to add the hooks and extra
> functionality that mod_dav_acl requires, but for some reason cannot be
> external to mod_dav.c (don't ask me why, I won't pretend to understand
> half of the code bases in question)
>
> I'm not sure if the approach being taken by the author of mod_dav_acl is
> correct in terms of the patch being applied to httpd, if there is a
> better way to approach the problem, or if there is a better place for
> discussion please advise, I'd be happy to file bugs against either httpd
> or mod_dav_acl, and quite possibly write some code, to get to the point
> where I don't need to custom-patch either side to make this work, and
> that they can both live in harmony and happy ever after.
>
> I'm attaching the suggested patch, I hope this is in order. The patch
> does apply cleanly to httpd-2.2.21, which I believe is currently the
> newest "stable" version.
>
> Kind Regards,
> Jaco
>
> [1] http://moddavacl.sourceforge.net/
> [2] http://modcaldav.sourceforge.net/
>
>
> ------------------------------------------------------------------------
>
>
> ---------------------------------------------------------------------
> The official User-To-User support forum of the Apache HTTP Server Project.
> See <URL:http://httpd.apache.org/userslist.html> for more info.
> To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
> " from the digest: users-digest-unsubscribe@httpd.apache.org
> For additional commands, e-mail: users-help@httpd.apache.org
---------------------------------------------------------------------
The official User-To-User support forum of the Apache HTTP Server Project.
See <URL:http://httpd.apache.org/userslist.html> for more info.
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
" from the digest: users-digest-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org