You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/22 15:48:15 UTC
[GitHub] [flink] slinkydeveloper opened a new pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
slinkydeveloper opened a new pull request #18885:
URL: https://github.com/apache/flink/pull/18885
## What is the purpose of the change
This change brings consistency to the FLIP-190 APIs and aligns them with the rest of the APIs.
Also pushed down `TableEnvironment#executePlan` and `TableEnvironment#explainPlan` from the upper interface to hide it to the user, as now everything is available in `CompiledPlan`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78255eb0fc41fc392d2112f8a42b7888e3f7f897 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78255eb0fc41fc392d2112f8a42b7888e3f7f897 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048)
* 46b41851c5ba695eb0293be9c63ad8399ccb7180 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816761680
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
##########
@@ -1103,54 +1103,21 @@ void createFunction(
*
* <p>Note: The compiled plan feature is not supported in batch mode.
*
- * @see #executePlan(CompiledPlan)
+ * @see CompiledPlan#execute()
* @see #loadPlan(PlanReference)
* @throws TableException if the SQL statement is invalid or if the plan cannot be persisted.
*/
@Experimental
CompiledPlan compilePlanSql(String stmt) throws TableException;
/**
- * Executes the provided {@link CompiledPlan}.
+ * Shorthand for {@code tEnv.loadPlan(planReference).execute()}.
*
- * <p>Compiled plans can be persisted and reloaded across Flink versions. They describe static
- * pipelines to ensure backwards compatibility and enable stateful streaming job upgrades. See
- * {@link CompiledPlan} and the website documentation for more information.
- *
- * <p>If a job is resumed from a savepoint, it will eventually resume the execution.
- *
- * <p>Note: The compiled plan feature is not supported in batch mode.
- *
- * @see #compilePlanSql(String)
* @see #loadPlan(PlanReference)
- */
- @Experimental
- TableResult executePlan(CompiledPlan plan);
-
- /**
- * Shorthand for {@code tEnv.executePlan(tEnv.loadPlan(planReference))}.
- *
- * @see #loadPlan(PlanReference)
- * @see #executePlan(CompiledPlan)
+ * @see CompiledPlan#execute()
Review comment:
sorry, I missed this
##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/utils/PlannerMock.java
##########
@@ -50,12 +50,12 @@ public String explain(List<Operation> operations, ExplainDetail... extraDetails)
}
@Override
- public CompiledPlan loadPlan(PlanReference planReference) throws IOException {
+ public CompiledPlanInternalFactory loadPlan(PlanReference planReference) throws IOException {
Review comment:
The `Explainable` was working before. We are just discussing `Executable` here. I don't think it makes a difference whether we throw an `UnsupportedOperationException` for `execute()` or throw an exception if the dependency injection has not performed.
Passing a `Function<CompiledPlan, TableResult>` argument is also not nice.
I don't have a better idea. So let's just shorten the name to `CompiledPlanFactory` and stick to this design. But I have the feeling the class structure gets more and more complex for no reason. Also the need for `CompiledPlanInternal` is weak. `TableEnvironmentInternal` has actually a comment about `Once old planner is removed, this class also can be removed.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46b41851c5ba695eb0293be9c63ad8399ccb7180 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816593184
##########
File path: flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/TableCsvFormatITCase.java
##########
@@ -46,9 +45,7 @@ public void testProjectPushDown() throws Exception {
createSourceTable("MyTable", data, "a bigint", "b int not null", "c varchar");
File sinkPath = createSinkTable("MySink", "a bigint", "c varchar");
- CompiledPlan compiledPlan =
- tableEnv.compilePlanSql("insert into MySink select a, c from MyTable");
- tableEnv.executePlan(compiledPlan).await();
+ tableEnv.compilePlanSql("insert into MySink select a, c from MyTable").execute().await();
Review comment:
why does the `TableCsvFormatITCase` uses a compiled plan? Looks like somebody didn't know about `executeSql`?
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/CompiledPlan.java
##########
@@ -27,7 +27,7 @@
import java.nio.file.Paths;
/**
- * Represents a static, executable entity that has been compiled from a Table & SQL API pipeline
+ * Represents an executable entity that has been compiled from a Table & SQL API pipeline
Review comment:
with `static` I meant to emphasize `immutable` or `fully optimized`
##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/utils/PlannerMock.java
##########
@@ -50,12 +50,12 @@ public String explain(List<Operation> operations, ExplainDetail... extraDetails)
}
@Override
- public CompiledPlan loadPlan(PlanReference planReference) throws IOException {
+ public CompiledPlanInternalFactory loadPlan(PlanReference planReference) throws IOException {
Review comment:
I don't like this additional indirection. The long `CompiledPlanInternalFactory` name already shows how "not so nice" the current approach is compared to the simplicity of the current `Planner` interface.
How about we simply throw an `UnsupportedOperationException` in the `CompiledPlan.execute()` returned by the planner by default and the TableEnvironment can simply wrap the `CompiledPlan` one more time to provide the executable functionality.
Another option would be to pass `TableEnvironmentInternal` to `loadPlan` and `compilePlan` but this is also not very nice because it creates a cyclic dependency.
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java
##########
@@ -126,4 +127,37 @@
*/
@Experimental
CompiledPlan compilePlan(List<ModifyOperation> operations);
+
+ /**
Review comment:
remove all JavaDocs. this is an internal class. it can only become outdated.
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
##########
@@ -1103,54 +1103,21 @@ void createFunction(
*
* <p>Note: The compiled plan feature is not supported in batch mode.
*
- * @see #executePlan(CompiledPlan)
+ * @see CompiledPlan#execute()
* @see #loadPlan(PlanReference)
* @throws TableException if the SQL statement is invalid or if the plan cannot be persisted.
*/
@Experimental
CompiledPlan compilePlanSql(String stmt) throws TableException;
/**
- * Executes the provided {@link CompiledPlan}.
+ * Shorthand for {@code tEnv.loadPlan(planReference).execute()}.
*
- * <p>Compiled plans can be persisted and reloaded across Flink versions. They describe static
- * pipelines to ensure backwards compatibility and enable stateful streaming job upgrades. See
- * {@link CompiledPlan} and the website documentation for more information.
- *
- * <p>If a job is resumed from a savepoint, it will eventually resume the execution.
- *
- * <p>Note: The compiled plan feature is not supported in batch mode.
- *
- * @see #compilePlanSql(String)
* @see #loadPlan(PlanReference)
- */
- @Experimental
- TableResult executePlan(CompiledPlan plan);
-
- /**
- * Shorthand for {@code tEnv.executePlan(tEnv.loadPlan(planReference))}.
- *
- * @see #loadPlan(PlanReference)
- * @see #executePlan(CompiledPlan)
+ * @see CompiledPlan#execute()
Review comment:
also link to `#load`
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/BatchPlanner.scala
##########
@@ -135,12 +135,13 @@ class BatchPlanner(
new BatchPlanner(executor, config, moduleManager, functionCatalog, catalogManager)
}
- override def loadPlan(planReference: PlanReference): CompiledPlanInternal = {
+ override def loadPlan(planReference: PlanReference): CompiledPlanInternalFactory = {
throw new UnsupportedOperationException(
"The compiled plan feature is not supported in batch mode.")
}
- override def compilePlan(modifyOperations: util.List[ModifyOperation]): CompiledPlanInternal =
+ override def compilePlan(
Review comment:
fix formatting
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/StreamPlanner.scala
##########
@@ -155,27 +155,18 @@ class StreamPlanner(
"Unknown PlanReference. This is a bug, please contact the developers")
}
- new ExecNodeGraphCompiledPlan(
- this,
- JsonSerdeUtil.createObjectWriter(createSerdeContext)
- .withDefaultPrettyPrinter()
- .writeValueAsString(execNodeGraph),
- execNodeGraph)
+ createCompiledPlanInternalFactory(ctx, execNodeGraph)
}
- override def compilePlan(modifyOperations: util.List[ModifyOperation]): CompiledPlanInternal = {
+ override def compilePlan(
Review comment:
formatting here and below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78255eb0fc41fc392d2112f8a42b7888e3f7f897 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816904314
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/InternalPlan.java
##########
@@ -16,19 +16,35 @@
* limitations under the License.
*/
-package org.apache.flink.table.api.internal;
+package org.apache.flink.table.delegation;
+import org.apache.flink.FlinkVersion;
import org.apache.flink.annotation.Internal;
import org.apache.flink.table.api.CompiledPlan;
+import org.apache.flink.table.api.TableEnvironment;
+import java.io.File;
import java.util.List;
/**
- * Internal interface of {@link CompiledPlan} containing methods used by {@link
- * TableEnvironmentInternal} implementation.
+ * Internal interface wrapping a plan. This is used in order to propagate the plan back and forth
+ * the {@link Planner} interface. The {@link TableEnvironment} wraps it in an implementation of
+ * {@link CompiledPlan}, to provide the fluent user-friendly interface.
*/
@Internal
-public interface CompiledPlanInternal extends CompiledPlan {
+public interface InternalPlan {
+
+ /** @see CompiledPlan#asJsonString() */
+ String asJsonString();
+
+ /**
+ * Note that {@code ignoreIfExists} has precedence over {@code failIfExists}.
+ *
+ * @see CompiledPlan#writeToFile(File, boolean) */
Review comment:
this should let spotless fail, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816655808
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
##########
@@ -1103,54 +1103,21 @@ void createFunction(
*
* <p>Note: The compiled plan feature is not supported in batch mode.
*
- * @see #executePlan(CompiledPlan)
+ * @see CompiledPlan#execute()
* @see #loadPlan(PlanReference)
* @throws TableException if the SQL statement is invalid or if the plan cannot be persisted.
*/
@Experimental
CompiledPlan compilePlanSql(String stmt) throws TableException;
/**
- * Executes the provided {@link CompiledPlan}.
+ * Shorthand for {@code tEnv.loadPlan(planReference).execute()}.
*
- * <p>Compiled plans can be persisted and reloaded across Flink versions. They describe static
- * pipelines to ensure backwards compatibility and enable stateful streaming job upgrades. See
- * {@link CompiledPlan} and the website documentation for more information.
- *
- * <p>If a job is resumed from a savepoint, it will eventually resume the execution.
- *
- * <p>Note: The compiled plan feature is not supported in batch mode.
- *
- * @see #compilePlanSql(String)
* @see #loadPlan(PlanReference)
- */
- @Experimental
- TableResult executePlan(CompiledPlan plan);
-
- /**
- * Shorthand for {@code tEnv.executePlan(tEnv.loadPlan(planReference))}.
- *
- * @see #loadPlan(PlanReference)
- * @see #executePlan(CompiledPlan)
+ * @see CompiledPlan#execute()
Review comment:
Which load are you referring to? it's already linked to `loadPlan`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
}, {
"hash" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366",
"triggerID" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"triggerType" : "PUSH"
}, {
"hash" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382",
"triggerID" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bcbc971ee3d9936a361450c4f251d4527f2a545c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366)
* 3416d151ed6a768cb17de796fbfeae69ac5b0694 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
}, {
"hash" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366",
"triggerID" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"triggerType" : "PUSH"
}, {
"hash" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46b41851c5ba695eb0293be9c63ad8399ccb7180 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352)
* bcbc971ee3d9936a361450c4f251d4527f2a545c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366)
* 3416d151ed6a768cb17de796fbfeae69ac5b0694 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
}, {
"hash" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366",
"triggerID" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"triggerType" : "PUSH"
}, {
"hash" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382",
"triggerID" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"triggerType" : "PUSH"
}, {
"hash" : "0c8e8280cf13ea915f65f70d1c5e626d7a08167f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c8e8280cf13ea915f65f70d1c5e626d7a08167f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3416d151ed6a768cb17de796fbfeae69ac5b0694 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382)
* 0c8e8280cf13ea915f65f70d1c5e626d7a08167f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816654882
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/CompiledPlan.java
##########
@@ -27,7 +27,7 @@
import java.nio.file.Paths;
/**
- * Represents a static, executable entity that has been compiled from a Table & SQL API pipeline
+ * Represents an executable entity that has been compiled from a Table & SQL API pipeline
Review comment:
what about just using `immutable` and `fully optimized` then? Check now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18885:
URL: https://github.com/apache/flink/pull/18885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937955
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 78255eb0fc41fc392d2112f8a42b7888e3f7f897 (Tue Feb 22 15:52:49 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78255eb0fc41fc392d2112f8a42b7888e3f7f897 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816789530
##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/utils/PlannerMock.java
##########
@@ -50,12 +50,12 @@ public String explain(List<Operation> operations, ExplainDetail... extraDetails)
}
@Override
- public CompiledPlan loadPlan(PlanReference planReference) throws IOException {
+ public CompiledPlanInternalFactory loadPlan(PlanReference planReference) throws IOException {
Review comment:
I pushed the name change.
One other possible solution is to make `CompiledPlanInternal` not extend `CompiledPlan`, and add to `CompiledPlanInternal` the `writeToFile`, `asJsonString` and `getFlinkVersion`. This way, the "user functionalities" of `CompiledPlan` are implemented in a wrapper class, which implements the full contract of `CompiledPlan`. Then `ExecNodeCompiledPlan` needs to implement only these 3 methods + `getSinkIdentifiers`, and the rest of the "user fluent APIs" are implemented by the wrapper.
This IMO really solves the issue in an elegant way, although a bit verbosely, but only internally in the `TableEnvironmentImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78255eb0fc41fc392d2112f8a42b7888e3f7f897 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048)
* 46b41851c5ba695eb0293be9c63ad8399ccb7180 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
}, {
"hash" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366",
"triggerID" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"triggerType" : "PUSH"
}, {
"hash" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382",
"triggerID" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"triggerType" : "PUSH"
}, {
"hash" : "0c8e8280cf13ea915f65f70d1c5e626d7a08167f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32418",
"triggerID" : "0c8e8280cf13ea915f65f70d1c5e626d7a08167f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c8e8280cf13ea915f65f70d1c5e626d7a08167f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816862870
##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/utils/PlannerMock.java
##########
@@ -50,12 +50,12 @@ public String explain(List<Operation> operations, ExplainDetail... extraDetails)
}
@Override
- public CompiledPlan loadPlan(PlanReference planReference) throws IOException {
+ public CompiledPlanInternalFactory loadPlan(PlanReference planReference) throws IOException {
Review comment:
I think properly splitting API from internal `CompiledPlan` makes sense. I was also thinking about this.
So:
- `CompiledPlan` = API
- `InternalPlan` = used for all `Planner` methods
Let's try to not use `CompiledPlanInternal` if it doesn't extend from `CompiledPlan` anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816908718
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/InternalPlan.java
##########
@@ -16,19 +16,35 @@
* limitations under the License.
*/
-package org.apache.flink.table.api.internal;
+package org.apache.flink.table.delegation;
+import org.apache.flink.FlinkVersion;
import org.apache.flink.annotation.Internal;
import org.apache.flink.table.api.CompiledPlan;
+import org.apache.flink.table.api.TableEnvironment;
+import java.io.File;
import java.util.List;
/**
- * Internal interface of {@link CompiledPlan} containing methods used by {@link
- * TableEnvironmentInternal} implementation.
+ * Internal interface wrapping a plan. This is used in order to propagate the plan back and forth
+ * the {@link Planner} interface. The {@link TableEnvironment} wraps it in an implementation of
+ * {@link CompiledPlan}, to provide the fluent user-friendly interface.
*/
@Internal
-public interface CompiledPlanInternal extends CompiledPlan {
+public interface InternalPlan {
+
+ /** @see CompiledPlan#asJsonString() */
+ String asJsonString();
+
+ /**
+ * Note that {@code ignoreIfExists} has precedence over {@code failIfExists}.
+ *
+ * @see CompiledPlan#writeToFile(File, boolean) */
Review comment:
forgot to run it, sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816654280
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/CompiledPlan.java
##########
@@ -27,7 +27,7 @@
import java.nio.file.Paths;
/**
- * Represents a static, executable entity that has been compiled from a Table & SQL API pipeline
+ * Represents an executable entity that has been compiled from a Table & SQL API pipeline
Review comment:
Let's use `immutable` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816630290
##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/utils/PlannerMock.java
##########
@@ -50,12 +50,12 @@ public String explain(List<Operation> operations, ExplainDetail... extraDetails)
}
@Override
- public CompiledPlan loadPlan(PlanReference planReference) throws IOException {
+ public CompiledPlanInternalFactory loadPlan(PlanReference planReference) throws IOException {
Review comment:
TBH I think this is the way it should look, as this factory just underlines how I need a dependency injection before being able to use an object fulfilling the `CompiledPlan` interface. The fact that the name is not nice is a different problem, we can rename it to `CompiledPlanFactory` if you prefer.
IMHO using `UnsupportedOperationException` is not correct, as the object returned by `loadPlan` here would not respect the interface `CompiledPlan`, which is `Executable` and `Explainable`. It also makes reasoning about this code and the functionalities of these interfaces harder, as now I need to go look into the specific `ExecNodeCompiledPlan` implementation to find out that I need an additional wrapping to be able to implement the full `CompiledPlan` interface. I rather prefer to make `ExecNodeCompiledPlan` mutable and clarify that I need additional dependency injection before being able to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
}, {
"hash" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46b41851c5ba695eb0293be9c63ad8399ccb7180 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352)
* bcbc971ee3d9936a361450c4f251d4527f2a545c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
}, {
"hash" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366",
"triggerID" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46b41851c5ba695eb0293be9c63ad8399ccb7180 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352)
* bcbc971ee3d9936a361450c4f251d4527f2a545c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
}, {
"hash" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366",
"triggerID" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"triggerType" : "PUSH"
}, {
"hash" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382",
"triggerID" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3416d151ed6a768cb17de796fbfeae69ac5b0694 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18885: [FLINK-26131][table] CompiledPlan implements Executable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18885:
URL: https://github.com/apache/flink/pull/18885#issuecomment-1047937150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32048",
"triggerID" : "78255eb0fc41fc392d2112f8a42b7888e3f7f897",
"triggerType" : "PUSH"
}, {
"hash" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32352",
"triggerID" : "46b41851c5ba695eb0293be9c63ad8399ccb7180",
"triggerType" : "PUSH"
}, {
"hash" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32366",
"triggerID" : "bcbc971ee3d9936a361450c4f251d4527f2a545c",
"triggerType" : "PUSH"
}, {
"hash" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382",
"triggerID" : "3416d151ed6a768cb17de796fbfeae69ac5b0694",
"triggerType" : "PUSH"
}, {
"hash" : "0c8e8280cf13ea915f65f70d1c5e626d7a08167f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32418",
"triggerID" : "0c8e8280cf13ea915f65f70d1c5e626d7a08167f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3416d151ed6a768cb17de796fbfeae69ac5b0694 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32382)
* 0c8e8280cf13ea915f65f70d1c5e626d7a08167f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org