You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by ap...@apache.org on 2007/12/06 16:52:20 UTC
svn commit: r601764 - in
/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util:
HashMap.java LinkedHashMap.java
Author: apetrenko
Date: Thu Dec 6 07:52:19 2007
New Revision: 601764
URL: http://svn.apache.org/viewvc?rev=601764&view=rev
Log:
Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
improvements"
Modified:
harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
Modified: harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java?rev=601764&r1=601763&r2=601764&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java (original)
+++ harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java Thu Dec 6 07:52:19 2007
@@ -68,29 +68,24 @@
}
}
- static class HashMapIterator<E, KT, VT> implements Iterator<E> {
+ private static class AbstractMapIterator<K, V> {
private int position = 0;
-
int expectedModCount;
+ Entry<K, V> futureEntry;
+ Entry<K, V> currentEntry;
+ Entry<K, V> prevEntry;
- final MapEntry.Type<E, KT, VT> type;
-
- boolean canRemove = false;
-
- Entry<KT, VT> entry;
+ final HashMap<K, V> associatedMap;
- Entry<KT, VT> lastEntry;
- final HashMap<KT, VT> associatedMap;
-
- HashMapIterator(MapEntry.Type<E, KT, VT> value, HashMap<KT, VT> hm) {
+ AbstractMapIterator(HashMap<K, V> hm) {
associatedMap = hm;
- type = value;
expectedModCount = hm.modCount;
+ futureEntry = null;
}
public boolean hasNext() {
- if (entry != null) {
+ if (futureEntry != null) {
return true;
}
while (position < associatedMap.elementData.length) {
@@ -103,52 +98,84 @@
return false;
}
- void checkConcurrentMod() throws ConcurrentModificationException {
+ final void checkConcurrentMod() throws ConcurrentModificationException {
if (expectedModCount != associatedMap.modCount) {
throw new ConcurrentModificationException();
}
}
- public E next() {
+ final void makeNext() {
checkConcurrentMod();
if (!hasNext()) {
throw new NoSuchElementException();
}
-
- MapEntry<KT, VT> result;
- if (entry == null) {
- result = lastEntry = associatedMap.elementData[position++];
- entry = lastEntry.next;
+ if (futureEntry == null) {
+ currentEntry = associatedMap.elementData[position++];
+ futureEntry = currentEntry.next;
+ prevEntry = null;
} else {
- if (lastEntry.next != entry) {
- lastEntry = lastEntry.next;
+ if(currentEntry!=null){
+ prevEntry = currentEntry;
}
- result = entry;
- entry = entry.next;
+ currentEntry = futureEntry;
+ futureEntry = futureEntry.next;
}
- canRemove = true;
- return type.get(result);
}
- public void remove() {
+ public final void remove() {
checkConcurrentMod();
- if (!canRemove) {
+ if (currentEntry==null) {
throw new IllegalStateException();
}
-
- canRemove = false;
- associatedMap.modCount++;
- if (lastEntry.next == entry) {
- while (associatedMap.elementData[--position] == null) {
- // Do nothing
- }
- associatedMap.elementData[position] = associatedMap.elementData[position].next;
- entry = null;
+ if(prevEntry==null){
+ int index = currentEntry.origKeyHash & (associatedMap.elementData.length - 1);
+ //assert associatedMap.elementData[index] == currentEntry;
+ associatedMap.elementData[index] = associatedMap.elementData[index].next;
} else {
- lastEntry.next = entry;
+ prevEntry.next = currentEntry.next;
}
- associatedMap.elementCount--;
+ currentEntry = null;
expectedModCount++;
+ associatedMap.modCount++;
+ associatedMap.elementCount--;
+
+ }
+ }
+
+
+ private static class EntryIterator <K, V> extends AbstractMapIterator<K, V> implements Iterator<Map.Entry<K, V>> {
+
+ EntryIterator (HashMap<K, V> map) {
+ super(map);
+ }
+
+ public Map.Entry<K, V> next() {
+ makeNext();
+ return currentEntry;
+ }
+ }
+
+ private static class KeyIterator <K, V> extends AbstractMapIterator<K, V> implements Iterator<K> {
+
+ KeyIterator (HashMap<K, V> map) {
+ super(map);
+ }
+
+ public K next() {
+ makeNext();
+ return currentEntry.key;
+ }
+ }
+
+ private static class ValueIterator <K, V> extends AbstractMapIterator<K, V> implements Iterator<V> {
+
+ ValueIterator (HashMap<K, V> map) {
+ super(map);
+ }
+
+ public V next() {
+ makeNext();
+ return currentEntry.value;
}
}
@@ -175,9 +202,13 @@
@Override
public boolean remove(Object object) {
- if (contains(object)) {
- associatedMap.remove(((Map.Entry<?, ?>) object).getKey());
- return true;
+ if (object instanceof Map.Entry) {
+ Map.Entry<?, ?> oEntry = (Map.Entry<?, ?>) object;
+ Entry<KT,VT> entry = associatedMap.getEntry(oEntry.getKey());
+ if(valuesEq(entry, oEntry)) {
+ associatedMap.removeEntry(entry);
+ return true;
+ }
}
return false;
}
@@ -185,34 +216,29 @@
@Override
public boolean contains(Object object) {
if (object instanceof Map.Entry) {
- Object key = ((Map.Entry<?, ?>) object).getKey();
- Entry<KT, VT> entry;
- if (key == null) {
- entry = associatedMap.findNullKeyEntry();
- } else {
- int hash = key.hashCode();
- int index = hash & (associatedMap.elementData.length - 1);
- entry = associatedMap.findNonNullKeyEntry(key, index, hash);
- }
- return entry == null ? false : entry.equals(object);
+ Map.Entry<?, ?> oEntry = (Map.Entry<?, ?>) object;
+ Entry entry = associatedMap.getEntry(oEntry.getKey());
+ return valuesEq(entry, oEntry);
}
return false;
}
+ private static boolean valuesEq(Entry entry, Map.Entry<?, ?> oEntry) {
+ return (entry != null) &&
+ ((entry.value == null) ?
+ (oEntry.getValue() == null) :
+ (entry.value.equals(oEntry.getValue())));
+ }
+
@Override
public Iterator<Map.Entry<KT, VT>> iterator() {
- return new HashMapIterator<Map.Entry<KT, VT>, KT, VT>(
- new MapEntry.Type<Map.Entry<KT, VT>, KT, VT>() {
- public Map.Entry<KT, VT> get(MapEntry<KT, VT> entry) {
- return entry;
- }
- }, associatedMap);
+ return new EntryIterator<KT,VT> (associatedMap);
}
}
/**
* Create a new element array
- *
+ *
* @param s
* @return Reference to the element array
*/
@@ -223,7 +249,7 @@
/**
* Constructs a new empty instance of HashMap.
- *
+ *
*/
public HashMap() {
this(DEFAULT_SIZE);
@@ -231,10 +257,10 @@
/**
* Constructs a new instance of HashMap with the specified capacity.
- *
+ *
* @param capacity
* the initial capacity of this HashMap
- *
+ *
* @exception IllegalArgumentException
* when the capacity is less than zero
*/
@@ -249,7 +275,7 @@
throw new IllegalArgumentException();
}
}
-
+
private static final int calculateCapacity(int x) {
if(x >= 1 << 30){
return 1 << 30;
@@ -269,13 +295,13 @@
/**
* Constructs a new instance of HashMap with the specified capacity and load
* factor.
- *
- *
+ *
+ *
* @param capacity
* the initial capacity
* @param loadFactor
* the initial load factor
- *
+ *
* @exception IllegalArgumentException
* when the capacity is less than zero or the load factor is
* less or equal to zero
@@ -295,7 +321,7 @@
/**
* Constructs a new instance of HashMap containing the mappings from the
* specified Map.
- *
+ *
* @param map
* the mappings to add
*/
@@ -306,7 +332,7 @@
/**
* Removes all mappings from this HashMap, leaving it empty.
- *
+ *
* @see #isEmpty
* @see #size
*/
@@ -321,9 +347,9 @@
/**
* Answers a new HashMap with the same mappings and size as this HashMap.
- *
+ *
* @return a shallow copy of this HashMap
- *
+ *
* @see java.lang.Cloneable
*/
@Override
@@ -355,7 +381,7 @@
/**
* Searches this HashMap for the specified key.
- *
+ *
* @param key
* the object to search for
* @return true if <code>key</code> is a key of this HashMap, false
@@ -363,20 +389,13 @@
*/
@Override
public boolean containsKey(Object key) {
- Entry<K, V> m;
- if (key == null) {
- m = findNullKeyEntry();
- } else {
- int hash = key.hashCode();
- int index = hash & (elementData.length - 1);
- m = findNonNullKeyEntry(key, index, hash);
- }
+ Entry<K, V> m = getEntry(key);
return m != null;
}
/**
* Searches this HashMap for the specified value.
- *
+ *
* @param value
* the object to search for
* @return true if <code>value</code> is a value of this HashMap, false
@@ -412,7 +431,7 @@
* Answers a Set of the mappings contained in this HashMap. Each element in
* the set is a Map.Entry. The set is backed by this HashMap so changes to
* one are reflected by the other. The set does not support adding.
- *
+ *
* @return a Set of the mappings
*/
@Override
@@ -422,13 +441,21 @@
/**
* Answers the value of the mapping with the specified key.
- *
+ *
* @param key
* the key
* @return the value of the mapping with the specified key
*/
@Override
public V get(Object key) {
+ Entry<K, V> m = getEntry(key);
+ if (m != null) {
+ return m.value;
+ }
+ return null;
+ }
+
+ final Entry<K, V> getEntry(Object key) {
Entry<K, V> m;
if (key == null) {
m = findNullKeyEntry();
@@ -437,10 +464,7 @@
int index = hash & (elementData.length - 1);
m = findNonNullKeyEntry(key, index, hash);
}
- if (m != null) {
- return m.value;
- }
- return null;
+ return m;
}
final Entry<K,V> findNonNullKeyEntry(Object key, int index, int keyHash) {
@@ -450,7 +474,7 @@
}
return m;
}
-
+
final Entry<K,V> findNullKeyEntry() {
Entry<K,V> m = elementData[0];
while (m != null && m.key != null)
@@ -460,9 +484,9 @@
/**
* Answers if this HashMap has no elements, a size of zero.
- *
+ *
* @return true if this HashMap has no elements, false otherwise
- *
+ *
* @see #size
*/
@Override
@@ -474,7 +498,7 @@
* Answers a Set of the keys contained in this HashMap. The set is backed by
* this HashMap so changes to one are reflected by the other. The set does
* not support adding.
- *
+ *
* @return a Set of the keys
*/
@Override
@@ -504,12 +528,7 @@
@Override
public Iterator<K> iterator() {
- return new HashMapIterator<K, K, V>(
- new MapEntry.Type<K, K, V>() {
- public K get(MapEntry<K, V> entry) {
- return entry.key;
- }
- }, HashMap.this);
+ return new KeyIterator<K,V> (HashMap.this);
}
};
}
@@ -518,7 +537,7 @@
/**
* Maps the specified key to the specified value.
- *
+ *
* @param key
* the key
* @param value
@@ -579,7 +598,7 @@
* Copies all the mappings in the given map to this map. These mappings will
* replace all mappings that this map had for any of the keys currently in
* the given map.
- *
+ *
* @param map
* the Map to copy mappings from
* @throws NullPointerException
@@ -626,7 +645,7 @@
/**
* Removes a mapping with the specified key from this HashMap.
- *
+ *
* @param key
* the key of the mapping to remove
* @return the value of the removed mapping or null if key is not a key in
@@ -641,7 +660,23 @@
return null;
}
- Entry<K, V> removeEntry(Object key) {
+ final void removeEntry(Entry<K, V> entry) {
+ int index = entry.origKeyHash & (elementData.length - 1);
+ Entry<K, V> m = elementData[index];
+ if (m == entry) {
+ elementData[index] = entry.next;
+ } else {
+ while (m.next != entry && m.next != null) {
+ m = m.next;
+ }
+ m.next = entry.next;
+
+ }
+ modCount++;
+ elementCount--;
+ }
+
+ final Entry<K, V> removeEntry(Object key) {
int index = 0;
Entry<K, V> entry;
Entry<K, V> last = null;
@@ -675,7 +710,7 @@
/**
* Answers the number of mappings in this HashMap.
- *
+ *
* @return the number of mappings in this HashMap
*/
@Override
@@ -687,7 +722,7 @@
* Answers a Collection of the values contained in this HashMap. The
* collection is backed by this HashMap so changes to one are reflected by
* the other. The collection does not support adding.
- *
+ *
* @return a Collection of the values
*/
@Override
@@ -711,12 +746,7 @@
@Override
public Iterator<V> iterator() {
- return new HashMapIterator<V, K, V>(
- new MapEntry.Type<V, K, V>() {
- public V get(MapEntry<K, V> entry) {
- return entry.value;
- }
- }, HashMap.this);
+ return new ValueIterator<K,V> (HashMap.this);
}
};
}
Modified: harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java?rev=601764&r1=601763&r2=601764&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java (original)
+++ harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java Thu Dec 6 07:52:19 2007
@@ -107,62 +107,47 @@
putAll(m);
}
- static final class LinkedHashIterator<E, KT, VT> extends
- HashMapIterator<E, KT, VT> {
- LinkedHashIterator(MapEntry.Type<E, KT, VT> value,
- LinkedHashMap<KT, VT> hm) {
- super(value, hm);
- entry = hm.head;
+ private static class AbstractMapIterator<K, V> {
+ int expectedModCount;
+ LinkedHashMapEntry<K, V> futureEntry;
+ LinkedHashMapEntry<K, V> currentEntry;
+ final LinkedHashMap<K, V> associatedMap;
+
+ AbstractMapIterator(LinkedHashMap<K, V> map) {
+ expectedModCount = map.modCount;
+ futureEntry = map.head;
+ associatedMap = map;
}
- @Override
public boolean hasNext() {
- return (entry != null);
+ return (futureEntry != null);
}
- @Override
- public E next() {
+ final void checkConcurrentMod() throws ConcurrentModificationException {
+ if (expectedModCount != associatedMap.modCount) {
+ throw new ConcurrentModificationException();
+ }
+ }
+
+ final void makeNext() {
checkConcurrentMod();
if (!hasNext()) {
throw new NoSuchElementException();
}
- E result = type.get(entry);
- lastEntry = entry;
- entry = ((LinkedHashMapEntry<KT, VT>) entry).chainForward;
- canRemove = true;
- return result;
+ currentEntry = futureEntry;
+ futureEntry = futureEntry.chainForward;
}
- @Override
public void remove() {
checkConcurrentMod();
- if (!canRemove) {
+ if (currentEntry==null) {
throw new IllegalStateException();
}
-
- canRemove = false;
- associatedMap.modCount++;
-
- int index = (lastEntry.key == null) ? 0
- : (lastEntry.key.hashCode() & 0x7FFFFFFF)
- % associatedMap.elementData.length;
- LinkedHashMapEntry<KT, VT> m = (LinkedHashMapEntry<KT, VT>) associatedMap.elementData[index];
- if (m == lastEntry) {
- associatedMap.elementData[index] = lastEntry.next;
- } else {
- while (m.next != null) {
- if (m.next == lastEntry) {
- break;
- }
- m = (LinkedHashMapEntry<KT, VT>) m.next;
- }
- // assert m.next == entry
- m.next = lastEntry.next;
- }
- LinkedHashMapEntry<KT, VT> lhme = (LinkedHashMapEntry<KT, VT>) lastEntry;
- LinkedHashMapEntry<KT, VT> p = lhme.chainBackward;
- LinkedHashMapEntry<KT, VT> n = lhme.chainForward;
- LinkedHashMap<KT, VT> lhm = (LinkedHashMap<KT, VT>) associatedMap;
+ associatedMap.removeEntry(currentEntry);
+ LinkedHashMapEntry<K, V> lhme = currentEntry;
+ LinkedHashMapEntry<K, V> p = lhme.chainBackward;
+ LinkedHashMapEntry<K, V> n = lhme.chainForward;
+ LinkedHashMap<K, V> lhm = associatedMap;
if (p != null) {
p.chainForward = n;
if (n != null) {
@@ -178,11 +163,47 @@
lhm.tail = null;
}
}
- associatedMap.elementCount--;
+ currentEntry = null;
expectedModCount++;
}
}
+ private static class EntryIterator <K, V> extends AbstractMapIterator<K, V> implements Iterator<Map.Entry<K, V>> {
+
+ EntryIterator (LinkedHashMap<K, V> map) {
+ super(map);
+ }
+
+ public Map.Entry<K, V> next() {
+ makeNext();
+ return currentEntry;
+ }
+ }
+
+ private static class KeyIterator <K, V> extends AbstractMapIterator<K, V> implements Iterator<K> {
+
+ KeyIterator (LinkedHashMap<K, V> map) {
+ super(map);
+ }
+
+ public K next() {
+ makeNext();
+ return currentEntry.key;
+ }
+ }
+
+ private static class ValueIterator <K, V> extends AbstractMapIterator<K, V> implements Iterator<V> {
+
+ ValueIterator (LinkedHashMap<K, V> map) {
+ super(map);
+ }
+
+ public V next() {
+ makeNext();
+ return currentEntry.value;
+ }
+ }
+
static final class LinkedHashMapEntrySet<KT, VT> extends
HashMapEntrySet<KT, VT> {
public LinkedHashMapEntrySet(LinkedHashMap<KT, VT> lhm) {
@@ -191,12 +212,7 @@
@Override
public Iterator<Map.Entry<KT, VT>> iterator() {
- return new LinkedHashIterator<Map.Entry<KT, VT>, KT, VT>(
- new MapEntry.Type<Map.Entry<KT, VT>, KT, VT>() {
- public Map.Entry<KT, VT> get(MapEntry<KT, VT> entry) {
- return entry;
- }
- }, (LinkedHashMap<KT, VT>) hashMap());
+ return new EntryIterator<KT,VT>((LinkedHashMap<KT, VT>) hashMap());
}
}
@@ -494,12 +510,7 @@
@Override
public Iterator<K> iterator() {
- return new LinkedHashIterator<K, K, V>(
- new MapEntry.Type<K, K, V>() {
- public K get(MapEntry<K, V> entry) {
- return entry.key;
- }
- }, LinkedHashMap.this);
+ return new KeyIterator<K,V>(LinkedHashMap.this);
}
};
}
@@ -534,12 +545,7 @@
@Override
public Iterator<V> iterator() {
- return new LinkedHashIterator<V, K, V>(
- new MapEntry.Type<V, K, V>() {
- public V get(MapEntry<K, V> entry) {
- return entry.value;
- }
- }, LinkedHashMap.this);
+ return new ValueIterator<K,V>(LinkedHashMap.this);
}
};
}
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util: HashMap.java LinkedHashMap.java
Posted by Mark Hindess <ma...@googlemail.com>.
On 6 December 2007 at 16:19, Tim Ellison <t....@gmail.com> wrote:
>
> Surely this is new function that should wait until the completion of
> this stability drive?
+1
This should definitely have waited for M5.
-Mark.
> apetrenko@apache.org wrote:
> > Author: apetrenko
> > Date: Thu Dec 6 07:52:19 2007
> > New Revision: 601764
> >
> > URL: http://svn.apache.org/viewvc?rev=601764&view=rev
> > Log:
> > Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
> > improvements"
> >
> > Modified:
> > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Ha
> shMap.java
> > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Li
> nkedHashMap.java
>
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util: HashMap.java LinkedHashMap.java
Posted by Sergey Dmitriev <se...@gmail.com>.
Tim
Yes, actually there is no big rush. I understand it can be late but
anyway: if this fix breaks the stability - feel free to roll it back.
You say "potato" I say "right, probably this is completely potato". :)
Thanks
Sergey
On Dec 7, 2007 8:45 PM, Tim Ellison <t....@gmail.com> wrote:
> You say "potato" and I say "potato" :-) either way it is a significant
> change to a sensitive part of the core library code just as we are
> trying to stabilize it. Where's the rush? You could add it in eight
> days from now without any argument.
>
> Regards,
> Tim
>
>
>
> Sergey Dmitriev wrote:
> > Tim
> >
> > this is not a new functionality but the performance improvement.
> > Specifically for an application server performance. This should not
> > touch the stability of current Harmony.
> >
> >
> > Thanks
> > Sergey
> >
> >
> > On Dec 6, 2007 7:19 PM, Tim Ellison <t....@gmail.com> wrote:
> >> Surely this is new function that should wait until the completion of
> >> this stability drive?
> >>
> >> Regards,
> >> Tim
> >>
> >> apetrenko@apache.org wrote:
> >>> Author: apetrenko
> >>> Date: Thu Dec 6 07:52:19 2007
> >>> New Revision: 601764
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=601764&view=rev
> >>> Log:
> >>> Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
> >>> improvements"
> >>>
> >>> Modified:
> >>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
> >>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
> >
>
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util:
HashMap.java LinkedHashMap.java
Posted by Tim Ellison <t....@gmail.com>.
You say "potato" and I say "potato" :-) either way it is a significant
change to a sensitive part of the core library code just as we are
trying to stabilize it. Where's the rush? You could add it in eight
days from now without any argument.
Regards,
Tim
Sergey Dmitriev wrote:
> Tim
>
> this is not a new functionality but the performance improvement.
> Specifically for an application server performance. This should not
> touch the stability of current Harmony.
>
>
> Thanks
> Sergey
>
>
> On Dec 6, 2007 7:19 PM, Tim Ellison <t....@gmail.com> wrote:
>> Surely this is new function that should wait until the completion of
>> this stability drive?
>>
>> Regards,
>> Tim
>>
>> apetrenko@apache.org wrote:
>>> Author: apetrenko
>>> Date: Thu Dec 6 07:52:19 2007
>>> New Revision: 601764
>>>
>>> URL: http://svn.apache.org/viewvc?rev=601764&view=rev
>>> Log:
>>> Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
>>> improvements"
>>>
>>> Modified:
>>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
>>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
>
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util: HashMap.java LinkedHashMap.java
Posted by Sergey Dmitriev <se...@gmail.com>.
Tim
this is not a new functionality but the performance improvement.
Specifically for an application server performance. This should not
touch the stability of current Harmony.
Thanks
Sergey
On Dec 6, 2007 7:19 PM, Tim Ellison <t....@gmail.com> wrote:
> Surely this is new function that should wait until the completion of
> this stability drive?
>
> Regards,
> Tim
>
> apetrenko@apache.org wrote:
> > Author: apetrenko
> > Date: Thu Dec 6 07:52:19 2007
> > New Revision: 601764
> >
> > URL: http://svn.apache.org/viewvc?rev=601764&view=rev
> > Log:
> > Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
> > improvements"
> >
> > Modified:
> > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
> > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
>
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util:
HashMap.java LinkedHashMap.java
Posted by Tim Ellison <t....@gmail.com>.
Surely this is new function that should wait until the completion of
this stability drive?
Regards,
Tim
apetrenko@apache.org wrote:
> Author: apetrenko
> Date: Thu Dec 6 07:52:19 2007
> New Revision: 601764
>
> URL: http://svn.apache.org/viewvc?rev=601764&view=rev
> Log:
> Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
> improvements"
>
> Modified:
> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java