You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/02 06:44:47 UTC

[GitHub] [flink] Airblader commented on a change in pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module

Airblader commented on a change in pull request #16042:
URL: https://github.com/apache/flink/pull/16042#discussion_r643694710



##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryTestBase.java
##########
@@ -410,24 +414,64 @@ public void testTableSinkWithLegacyProperties() {
     }
 
     protected Map<String, String> createKafkaSinkProperties() {
-        return new TestTableDescriptor(
-                        new Kafka()
-                                .version(getKafkaVersion())
-                                .topic(TOPIC)
-                                .properties(KAFKA_PROPERTIES)
-                                .sinkPartitionerFixed()
-                                .startFromSpecificOffsets(
-                                        OFFSETS)) // test if they accepted although not needed
-                .withFormat(new TestTableFormat())
-                .withSchema(
-                        new Schema()
-                                .field(FRUIT_NAME, DataTypes.STRING())
-                                .field(COUNT, DataTypes.DECIMAL(10, 4))
-                                .field(EVENT_TIME, DataTypes.TIMESTAMP(3)))
-                .inAppendMode()
-                .toProperties();
+        final Map<String, String> map = new HashMap<>();
+        map.put("schema.0.data-type", "VARCHAR(2147483647)");

Review comment:
       nit: why not `STRING`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org