[GitHub] [iceberg] rdblue commented on a diff in pull request #5338: Spec: Inconsistency around files_count

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5338:
URL: https://github.com/apache/iceberg/pull/5338#discussion_r927752961


##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -41,11 +41,11 @@ public interface ManifestFile {
       "Lowest sequence number in the manifest");
   Types.NestedField SNAPSHOT_ID = optional(503, "added_snapshot_id", Types.LongType.get(),
       "Snapshot ID that added the manifest");
-  Types.NestedField ADDED_FILES_COUNT = optional(504, "added_data_files_count", Types.IntegerType.get(),
+  Types.NestedField ADDED_DATA_FILES_COUNT = optional(504, "added_data_files_count", Types.IntegerType.get(),

Review Comment:
   These changes look good to me. I think we can also update the field names. Those won't break anything because the only names that matter are the ones in the read schema.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org