You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/11/02 11:36:26 UTC
Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: fixed ambiguousity error in `process/owned.hpp`.
Diffs
-----
3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
Diff: https://reviews.apache.org/r/39851/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/#review104695
-----------------------------------------------------------
3rdparty/libprocess/include/process/owned.hpp (line 122)
<https://reviews.apache.org/r/39851/#comment162948>
Ah. VisualStudio tricked me into believing this was ok! It claimed this built correctly, but now when I `make clean` it doesn't. I'll have to revisit tomorrow, as it's 3:30 AM.
- Alex Clemmer
On Nov. 2, 2015, 11:06 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39851/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 11:06 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: fixed ambiguousity error in `process/owned.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
>
> Diff: https://reviews.apache.org/r/39851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/#review110346
-----------------------------------------------------------
3rdparty/libprocess/include/process/owned.hpp (lines 122 - 127)
<https://reviews.apache.org/r/39851/#comment170158>
This is a really long `NOTE:` considering the issue.
3rdparty/libprocess/include/process/owned.hpp (line 128)
<https://reviews.apache.org/r/39851/#comment170159>
let's use a static cast?
- Joris Van Remoortere
On Nov. 16, 2015, 9:14 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39851/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:14 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: fixed ambiguousity error in `process/owned.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
>
> Diff: https://reviews.apache.org/r/39851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 9:14 a.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: fixed ambiguousity error in `process/owned.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
Diff: https://reviews.apache.org/r/39851/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/#review105926
-----------------------------------------------------------
Ship it!
Double-checked non-Windows build.
- Joseph Wu
On Nov. 2, 2015, 11:56 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39851/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 11:56 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: fixed ambiguousity error in `process/owned.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
>
> Diff: https://reviews.apache.org/r/39851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 7:56 p.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: fixed ambiguousity error in `process/owned.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
Diff: https://reviews.apache.org/r/39851/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 6:35 p.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: fixed ambiguousity error in `process/owned.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
Diff: https://reviews.apache.org/r/39851/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 6:30 p.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: fixed ambiguousity error in `process/owned.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
Diff: https://reviews.apache.org/r/39851/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 11:06 a.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: fixed ambiguousity error in `process/owned.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
Diff: https://reviews.apache.org/r/39851/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39851: Windows: fixed ambiguousity error in
`process/owned.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 11:02 a.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: fixed ambiguousity error in `process/owned.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05
Diff: https://reviews.apache.org/r/39851/diff/
Testing
-------
Thanks,
Alex Clemmer