You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/04 08:08:45 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #34308: [SPARK-37035][SQL] Improve error message when use parquet vectorize reader

cloud-fan commented on a change in pull request #34308:
URL: https://github.com/apache/spark/pull/34308#discussion_r742609607



##########
File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetDictionary.java
##########
@@ -17,60 +17,92 @@
 
 package org.apache.spark.sql.execution.datasources.parquet;
 
+import org.apache.spark.sql.errors.QueryExecutionErrors;
 import org.apache.spark.sql.execution.vectorized.Dictionary;
 
 import java.math.BigInteger;
 
 public final class ParquetDictionary implements Dictionary {
   private org.apache.parquet.column.Dictionary dictionary;
+  private String file;

Review comment:
       I think `path` is a better name here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org