You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/03 21:24:26 UTC
[GitHub] [incubator-superset] etr2460 opened a new issue #8167: PUT requests
to /tablecolumninlineview/api/update/ fail
etr2460 opened a new issue #8167: PUT requests to /tablecolumninlineview/api/update/<id> fail
URL: https://github.com/apache/incubator-superset/issues/8167
Making a PUT request to the tablecolumninlineview api fails when not all required fields on the model are provided.
### Expected results
Expect a 200 when providing a payload of `{"description": description}`.
### Actual results
Get a 500
`{"error_details":{"column_name":["This field is required."]},"message":"Validation error","severity":"warning"}`
#### How to reproduce the bug
1. Create a dimension in superset
2. Hit the API to change the dimension description
3. Get an error
Note that when I include the `column_name` field, this doesn't fail. It seems like there's an issue with merging the payload with the existing object, perhaps with the model or in FAB. I would expect to not need the `column_name` field when making a PUT request if it already exists on the existing object
### Environment
Repros on superset master, up to date versions of python and js
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
cc @john-bodley @dpgaspar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org