You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/05/17 09:12:44 UTC

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #806: IGNITE-16935 [Native Persistence 3.0] Porting a checkpoint and related code, part 3

tkalkirill commented on code in PR #806:
URL: https://github.com/apache/ignite-3/pull/806#discussion_r874571326


##########
modules/core/src/main/java/org/apache/ignite/internal/components/LongJvmPauseDetector.java:
##########
@@ -51,7 +49,7 @@ public class LongJvmPauseDetector implements IgniteComponent {
     private static final int PRECISION = getInteger("IGNITE_JVM_PAUSE_DETECTOR_PRECISION", DFLT_JVM_PAUSE_DETECTOR_PRECISION);
 
     /** Threshold. */
-    private static final int THRESHOLD = getInteger("IGNITE_JVM_PAUSE_DETECTOR_THRESHOLD", DEFAULT_JVM_PAUSE_DETECTOR_THRESHOLD);
+    private final int threshold = getInteger("IGNITE_JVM_PAUSE_DETECTOR_THRESHOLD", 500);

Review Comment:
   I don't think it should be a constant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org