You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2014/11/27 01:19:19 UTC
Review Request 28491: Create server-side actions to create kerberos
principals and keytabs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/
-----------------------------------------------------------
Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-8454
https://issues.apache.org/jira/browse/AMBARI-8454
Repository: ambari
Description
-------
Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
Diffs
-----
ambari-project/pom.xml edba1dc
ambari-server/pom.xml e03b626
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/28491/diff/
Testing
-------
Added new unit tests:
Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:36.295s
[INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
[INFO] Final Memory: 43M/739M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/#review64291
-----------------------------------------------------------
Merged into trunk:
Results :
Tests run: 2354, Failures: 0, Errors: 0, Skipped: 22
- Robert Nettleton
On Dec. 8, 2014, 8:35 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28491/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 8:35 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8454
> https://issues.apache.org/jira/browse/AMBARI-8454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml 930080e
> ambari-server/pom.xml b11538d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28491/diff/
>
>
> Testing
> -------
>
> Added new unit tests:
>
> Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:36.295s
> [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
> [INFO] Final Memory: 43M/739M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/
-----------------------------------------------------------
(Updated Dec. 8, 2014, 3:35 p.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Changes
-------
Updates due to Ambari Directory Server library change - see [28799](https://reviews.apache.org/r/28799/)
Bugs: AMBARI-8454
https://issues.apache.org/jira/browse/AMBARI-8454
Repository: ambari
Description
-------
Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
Diffs (updated)
-----
ambari-project/pom.xml 930080e
ambari-server/pom.xml b11538d
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/28491/diff/
Testing
-------
Added new unit tests:
Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:36.295s
[INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
[INFO] Final Memory: 43M/739M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/
-----------------------------------------------------------
(Updated Dec. 8, 2014, 6:34 a.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Changes
-------
Needed updated Apache Directory Server library for bug fix - [DIRSERVER-1882](https://issues.apache.org/jira/browse/DIRSERVER-1882)
Bugs: AMBARI-8454
https://issues.apache.org/jira/browse/AMBARI-8454
Repository: ambari
Description
-------
Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
Diffs
-----
ambari-project/pom.xml edba1dc
ambari-server/pom.xml 4076d73
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/28491/diff/
Testing
-------
Added new unit tests:
Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:36.295s
[INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
[INFO] Final Memory: 43M/739M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 11:15 a.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Changes
-------
Removed multiple blank lines from end of `org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java`
Bugs: AMBARI-8454
https://issues.apache.org/jira/browse/AMBARI-8454
Repository: ambari
Description
-------
Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
Diffs (updated)
-----
ambari-project/pom.xml edba1dc
ambari-server/pom.xml 4076d73
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/28491/diff/
Testing
-------
Added new unit tests:
Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:36.295s
[INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
[INFO] Final Memory: 43M/739M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 5, 2014, 12:48 a.m., dilli dorai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java, line 149
> > <https://reviews.apache.org/r/28491/diff/3/?file=783485#file783485line149>
> >
> > We would need deleteServicePrincipal() method as well. But, this could be added in next phase.
Agreed
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/#review63965
-----------------------------------------------------------
On Dec. 4, 2014, 11:38 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28491/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 11:38 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8454
> https://issues.apache.org/jira/browse/AMBARI-8454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml edba1dc
> ambari-server/pom.xml 4076d73
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28491/diff/
>
>
> Testing
> -------
>
> Added new unit tests:
>
> Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:36.295s
> [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
> [INFO] Final Memory: 43M/739M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by dilli dorai <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/#review63965
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
<https://reviews.apache.org/r/28491/#comment106329>
We would need deleteServicePrincipal() method as well. But, this could be added in next phase.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
<https://reviews.apache.org/r/28491/#comment106340>
Noted the change here to process all records with one instance of handler and closing the handler in finally block.
Looks good.
- dilli dorai
On Dec. 5, 2014, 4:38 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28491/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 4:38 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8454
> https://issues.apache.org/jira/browse/AMBARI-8454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml edba1dc
> ambari-server/pom.xml 4076d73
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28491/diff/
>
>
> Testing
> -------
>
> Added new unit tests:
>
> Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:36.295s
> [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
> [INFO] Final Memory: 43M/739M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/
-----------------------------------------------------------
(Updated Dec. 4, 2014, 11:38 p.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Changes
-------
Optimized creation and cleanup of the KerberosOperation handler as requested by @dilli.dorai
Bugs: AMBARI-8454
https://issues.apache.org/jira/browse/AMBARI-8454
Repository: ambari
Description
-------
Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
Diffs (updated)
-----
ambari-project/pom.xml edba1dc
ambari-server/pom.xml 4076d73
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/28491/diff/
Testing
-------
Added new unit tests:
Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:36.295s
[INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
[INFO] Final Memory: 43M/739M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/
-----------------------------------------------------------
(Updated Dec. 2, 2014, 6:20 a.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Changes
-------
Addressed reviewer concerns.
Bugs: AMBARI-8454
https://issues.apache.org/jira/browse/AMBARI-8454
Repository: ambari
Description
-------
Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
Diffs (updated)
-----
ambari-project/pom.xml edba1dc
ambari-server/pom.xml e03b626
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/28491/diff/
Testing
-------
Added new unit tests:
Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:36.295s
[INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
[INFO] Final Memory: 43M/739M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 1, 2014, 11:47 a.m., Robert Nettleton wrote:
> > ambari-server/pom.xml, line 1389
> > <https://reviews.apache.org/r/28491/diff/1/?file=777044#file777044line1389>
> >
> > Since this dependency is also added to the ambari-project pom.xml, adding it here should not be necessary. The ambari-server pom.xml should just pull it in from it's parent pom.xml.
> >
> > I'd recommend removing it from here.
The declaration of this dependency in the parent is in the <dependencyManagement> block, not the <depencendy> block, therefore to get the ambari-server project to pull it in this line is needed.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/#review63371
-----------------------------------------------------------
On Nov. 26, 2014, 7:19 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28491/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 7:19 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8454
> https://issues.apache.org/jira/browse/AMBARI-8454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml edba1dc
> ambari-server/pom.xml e03b626
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28491/diff/
>
>
> Testing
> -------
>
> Added new unit tests:
>
> Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:36.295s
> [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
> [INFO] Final Memory: 43M/739M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/#review63371
-----------------------------------------------------------
Ship it!
Looks good, just added some minor issues to consider.
ambari-server/pom.xml
<https://reviews.apache.org/r/28491/#comment105599>
Since this dependency is also added to the ambari-project pom.xml, adding it here should not be necessary. The ambari-server pom.xml should just pull it in from it's parent pom.xml.
I'd recommend removing it from here.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
<https://reviews.apache.org/r/28491/#comment105611>
Might want to consider throwing an exception back to the caller for the error conditions at the top of this method.
If any of these parameters are null, then someone will have to analyze the log to try and determine why something failed. A stack trace with this message might be more straight-forward, unless there is a compelling reason not to throw an exception here.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
<https://reviews.apache.org/r/28491/#comment105612>
Same as above, the error-checking code on the parameters should probably throw an exception.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
<https://reviews.apache.org/r/28491/#comment105613>
Minor issue:
Should this javadoc read: "a Map to be used as..." ?
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
<https://reviews.apache.org/r/28491/#comment105614>
Same minor issue as above in the javadoc, probably should read "a Map to be used as..."
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
<https://reviews.apache.org/r/28491/#comment105615>
I'd recommend throwing an IllegalArgumentException here, instead of logging, to make debugging this simpler in the future.
- Robert Nettleton
On Nov. 27, 2014, 12:19 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28491/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 12:19 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8454
> https://issues.apache.org/jira/browse/AMBARI-8454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml edba1dc
> ambari-server/pom.xml e03b626
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28491/diff/
>
>
> Testing
> -------
>
> Added new unit tests:
>
> Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:36.295s
> [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
> [INFO] Final Memory: 43M/739M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 1, 2014, 11:03 a.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java, line 330
> > <https://reviews.apache.org/r/28491/diff/1/?file=777054#file777054line330>
> >
> > Is it required that the interface force a ConcurrentMap or could this be simply Map<String, Object>?
Changed this in revision 2 of the patch.
> On Dec. 1, 2014, 11:03 a.m., Tom Beerbower wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java, line 28
> > <https://reviews.apache.org/r/28491/diff/1/?file=777056#file777056line28>
> >
> > Minor : import not needed since you fully qualify each assertion (i.e. Assert.assertNotNull(file))
Fixed in revision 2 of the patch
> On Dec. 1, 2014, 11:03 a.m., Tom Beerbower wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java, lines 22-37
> > <https://reviews.apache.org/r/28491/diff/1/?file=777057#file777057line22>
> >
> > Minor : Optimize the imports.
Fixed in revision 2 of the patch
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/#review63372
-----------------------------------------------------------
On Dec. 2, 2014, 6:20 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28491/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 6:20 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8454
> https://issues.apache.org/jira/browse/AMBARI-8454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml edba1dc
> ambari-server/pom.xml e03b626
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28491/diff/
>
>
> Testing
> -------
>
> Added new unit tests:
>
> Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:36.295s
> [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
> [INFO] Final Memory: 43M/739M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 28491: Create server-side actions to create
kerberos principals and keytabs
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28491/#review63372
-----------------------------------------------------------
Ship it!
Looks good. Minor comments.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
<https://reviews.apache.org/r/28491/#comment105606>
Is it required that the interface force a ConcurrentMap or could this be simply Map<String, Object>?
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java
<https://reviews.apache.org/r/28491/#comment105600>
Minor : import not needed since you fully qualify each assertion (i.e. Assert.assertNotNull(file))
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java
<https://reviews.apache.org/r/28491/#comment105601>
Minor : Optimize the imports.
- Tom Beerbower
On Nov. 27, 2014, 12:19 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28491/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 12:19 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8454
> https://issues.apache.org/jira/browse/AMBARI-8454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create server-side actions to generate the Kerberos principals and keytabs. These actions will be used when setting up Kerberos for services when Kerberizing a cluster.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml edba1dc
> ambari-server/pom.xml e03b626
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28491/diff/
>
>
> Testing
> -------
>
> Added new unit tests:
>
> Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec
> Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:36.295s
> [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014
> [INFO] Final Memory: 43M/739M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>