You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/15 23:35:13 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #5154: Fix the NPE
for DISTINCT aggregation function when no record is selected
codecov-io commented on issue #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#issuecomment-599281290
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=h1) Report
> Merging [#5154](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/d989427ec076d4553206e9fdd062be24de50477d&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `91.07%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5154 +/- ##
============================================
- Coverage 66.10% 65.99% -0.11%
Complexity 12 12
============================================
Files 1052 1052
Lines 54151 54139 -12
Branches 8081 8075 -6
============================================
- Hits 35796 35731 -65
- Misses 15690 15743 +53
Partials 2665 2665
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...aggregation/function/AggregationFunctionUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVXRpbHMuamF2YQ==) | `95.23% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...gregation/function/AggregationFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uRmFjdG9yeS5qYXZh) | `80.39% <50.00%> (+0.39%)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/pinot/common/utils/DataSchema.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRGF0YVNjaGVtYS5qYXZh) | `85.29% <80.00%> (+0.03%)` | `0.00 <0.00> (ø)` | |
| [...regation/function/DistinctAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdEFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `77.08% <95.65%> (+3.75%)` | `0.00 <0.00> (ø)` | |
| [...he/pinot/core/common/datatable/DataTableUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZVV0aWxzLmphdmE=) | `90.36% <100.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
| [...he/pinot/core/operator/CombineGroupByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lR3JvdXBCeU9wZXJhdG9yLmphdmE=) | `83.69% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...rator/query/AggregationGroupByOrderByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9BZ2dyZWdhdGlvbkdyb3VwQnlPcmRlckJ5T3BlcmF0b3IuamF2YQ==) | `92.30% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...t/core/plan/AggregationGroupByOrderByPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uR3JvdXBCeU9yZGVyQnlQbGFuTm9kZS5qYXZh) | `31.25% <100.00%> (-1.41%)` | `0.00 <0.00> (ø)` | |
| [...he/pinot/core/plan/AggregationGroupByPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uR3JvdXBCeVBsYW5Ob2RlLmphdmE=) | `72.91% <100.00%> (-0.56%)` | `0.00 <0.00> (ø)` | |
| [...rg/apache/pinot/core/plan/AggregationPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uUGxhbk5vZGUuamF2YQ==) | `71.05% <100.00%> (-0.75%)` | `0.00 <0.00> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=footer). Last update [d989427...8dd77cf](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org