You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2019/06/03 16:33:16 UTC

[pulsar] branch master updated: Remove redundant readMoreEntries call in PersistentDispatcherMultipleConsumers and PersistentStickyKeyDispatcherMultipleConsumers (#4442)

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 116e88c  Remove redundant readMoreEntries call in PersistentDispatcherMultipleConsumers and PersistentStickyKeyDispatcherMultipleConsumers (#4442)
116e88c is described below

commit 116e88c8c3c75219d477a6dd4792a6bf47a8c911
Author: lipenghui <pe...@apache.org>
AuthorDate: Tue Jun 4 00:33:09 2019 +0800

    Remove redundant readMoreEntries call in PersistentDispatcherMultipleConsumers and PersistentStickyKeyDispatcherMultipleConsumers (#4442)
---
 .../service/persistent/PersistentDispatcherMultipleConsumers.java       | 2 +-
 .../persistent/PersistentStickyKeyDispatcherMultipleConsumers.java      | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
index ffc9ce2..fdb5f19 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
@@ -428,7 +428,6 @@ public class PersistentDispatcherMultipleConsumers extends AbstractDispatcherMul
         }
 
         sendMessagesToConsumers(readType, entries);
-        readMoreEntries();
     }
 
     protected void sendMessagesToConsumers(ReadType readType, List<Entry> entries) {
@@ -500,6 +499,7 @@ public class PersistentDispatcherMultipleConsumers extends AbstractDispatcherMul
                 entry.release();
             });
         }
+        readMoreEntries();
     }
 
     @Override
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
index e13a0c3..154e870 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
@@ -153,7 +153,6 @@ public class PersistentStickyKeyDispatcherMultipleConsumers extends PersistentDi
                     log.debug("[{}] No consumers found with available permits, storing {} positions for later replay", name,
                             laterReplay);
                 }
-                readMoreEntries();
             }
         }
     }