You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Petter Skott <lp...@dc.luth.se> on 2001/11/26 14:58:31 UTC
Broken configure...
I believe that i've found a problem with configure
(subversion-r364/464).
The following piece of c-code is used to verify the version of
Berkeley-DB (generated from ac-helpers/berkeley-db.m4).
#include <stdio.h>
#include "db.h"
main ()
{
int major, minor, patch;
db_version (&major, &minor, &patch);
if (major < $svn_check_berkeley_db_major)
exit (1);
if (major > $svn_check_berkeley_db_major)
exit (0);
if (minor < $svn_check_berkeley_db_minor)
exit (1);
if (minor > $svn_check_berkeley_db_minor)
exit (0);
if (patch >= $svn_check_berkeley_db_patch)
exit (0);
else
exit (1);
}
Consider the fact that the required version of BerkeleyDB is 3.3.11 (major
=3, minor = 3, patch = 11) which is also the latest version, the code
should be:
#include <stdio.h>
#include "db.h"
main ()
{
int major, minor, patch;
db_version (&major, &minor, &patch);
if (major < $svn_check_berkeley_db_major)
exit (1);
if (major >=B $svn_check_berkeley_db_major)
exit (0);
if (minor < $svn_check_berkeley_db_minor)
exit (1);
if (minor >= $svn_check_berkeley_db_minor)
exit (0);
if (patch >= $svn_check_berkeley_db_patch)
exit (0);
else
exit (1);
}
Or to be fully correct:
#include <stdio.h>
#include "db.h"
main ()
{
if (major < $svn_check_berkeley_db_major)
exit (1);
if (minor < $svn_check_berkeley_db_minor)
exit (1);
if (patch < $svn_check_berkeley_db_patch)
exit (1);
exit (0);
}
/Petter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Broken configure...
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Petter Skott <lp...@dc.luth.se> writes:
> Or to be fully correct:
>
> #include <stdio.h>
> #include "db.h"
> main ()
> {
> if (major < $svn_check_berkeley_db_major)
> exit (1);
> if (minor < $svn_check_berkeley_db_minor)
> exit (1);
> if (patch < $svn_check_berkeley_db_patch)
> exit (1);
> exit (0);
> }
Shouldn't that be:
#include <stdio.h>
#include "db.h"
main ()
{
if (major < $svn_check_berkeley_db_major)
exit (1);
else if (minor < $svn_check_berkeley_db_minor)
exit (1);
else if (patch < $svn_check_berkeley_db_patch)
exit (1);
exit (0);
}
(I changed two "if"s to "else if"s).
?,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Broken configure...
Posted by Mark Benedetto King <bk...@answerfriend.com>.
On Mon, Nov 26, 2001 at 03:58:31PM +0100, Petter Skott wrote:
>
> I believe that i've found a problem with configure
> (subversion-r364/464).
> The following piece of c-code is used to verify the version of
> Berkeley-DB (generated from ac-helpers/berkeley-db.m4).
>
[snip]
>
> Consider the fact that the required version of BerkeleyDB is 3.3.11 (major
> =3, minor = 3, patch = 11) which is also the latest version, the code
> should be:
>
> #include <stdio.h>
> #include "db.h"
> main ()
> {
> int major, minor, patch;
>
> db_version (&major, &minor, &patch);
>
> if (major < $svn_check_berkeley_db_major)
> exit (1);
> if (major >=B $svn_check_berkeley_db_major)
> exit (0);
>
> if (minor < $svn_check_berkeley_db_minor)
> exit (1);
> if (minor >= $svn_check_berkeley_db_minor)
> exit (0);
Let's say you had version 3.3.10. You don't
want to exit(0).
>
> if (patch >= $svn_check_berkeley_db_patch)
> exit (0);
> else
> exit (1);
> }
>
> Or to be fully correct:
>
> #include <stdio.h>
> #include "db.h"
> main ()
> {
> if (major < $svn_check_berkeley_db_major)
> exit (1);
> if (minor < $svn_check_berkeley_db_minor)
> exit (1);
Let's say you had version "4.0.0". You don't
want to exit(1).
> if (patch < $svn_check_berkeley_db_patch)
> exit (1);
> exit (0);
> }
>
> /Petter
>
>
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org