You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "hboutemy (via GitHub)" <gi...@apache.org> on 2023/05/06 21:48:36 UTC
[GitHub] [maven-site-plugin] hboutemy opened a new pull request, #152: [MSITE-965] configure system requirements history
hboutemy opened a new pull request, #152:
URL: https://github.com/apache/maven-site-plugin/pull/152
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] hboutemy commented on a diff in pull request #152: [MSITE-965] configure system requirements history
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #152:
URL: https://github.com/apache/maven-site-plugin/pull/152#discussion_r1186750754
##########
src/site/site.xml:
##########
@@ -25,7 +25,17 @@ under the License.
<body>
<menu name="Overview">
<item name="Introduction" href="index.html"/>
- <item name="Goals" href="plugin-info.html"/>
+ <item name="Goals" href="plugin-info.html" collapse="true">
+ <item name="site:site" href="site-mojo.html"/>
+ <item name="site:deploy" href="deploy-mojo.html"/>
+ <item name="site:run" href="run-mojo.html"/>
+ <item name="site:stage" href="stage-mojo.html"/>
+ <item name="site:stage-deploy" href="stage-deploy-mojo.html"/>
+ <item name="site:attach-descriptor" href="attach-descriptor-mojo.html"/>
+ <item name="site:jar" href="jar-mojo.html"/>
+ <item name="site:effective-site" href="effective-site-mojo.html"/>
+ <item name="site:help" href="help-mojo.html"/>
+ </item>
Review Comment:
yes, while at it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] michael-o commented on a diff in pull request #152: [MSITE-965] configure system requirements history
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #152:
URL: https://github.com/apache/maven-site-plugin/pull/152#discussion_r1186750633
##########
src/site/site.xml:
##########
@@ -25,7 +25,17 @@ under the License.
<body>
<menu name="Overview">
<item name="Introduction" href="index.html"/>
- <item name="Goals" href="plugin-info.html"/>
+ <item name="Goals" href="plugin-info.html" collapse="true">
+ <item name="site:site" href="site-mojo.html"/>
+ <item name="site:deploy" href="deploy-mojo.html"/>
+ <item name="site:run" href="run-mojo.html"/>
+ <item name="site:stage" href="stage-mojo.html"/>
+ <item name="site:stage-deploy" href="stage-deploy-mojo.html"/>
+ <item name="site:attach-descriptor" href="attach-descriptor-mojo.html"/>
+ <item name="site:jar" href="jar-mojo.html"/>
+ <item name="site:effective-site" href="effective-site-mojo.html"/>
+ <item name="site:help" href="help-mojo.html"/>
+ </item>
Review Comment:
Unrelated, no?
##########
pom.xml:
##########
@@ -507,6 +507,41 @@ under the License.
</dependency>
</dependencies>
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-plugin-report-plugin</artifactId>
+ <configuration>
+ <requirementsHistories>
+ <requirementsHistory>
+ <version>3.11.0</version>
+ <maven>3.0.5</maven>
+ <jdk>1.7</jdk>
+ </requirementsHistory>
+ <requirementsHistory>
+ <version>3.9.0</version>
+ <maven>3.0</maven>
+ <jdk>1.7</jdk>
+ </requirementsHistory>
+ <requirementsHistory>
+ <version>3.7.1</version>
+ <maven>2.2.1</maven>
+ <jdk>1.6</jdk>
+ </requirementsHistory>
+ <requirementsHistory>
+ <version>3.4</version>
+ <maven>2.2.1</maven>
+ <jdk>1.5</jdk>
+ </requirementsHistory>
+ </requirementsHistories>
+ </configuration>
Review Comment:
This seems to be incomplete, compared to the `history.apt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] michael-o commented on a diff in pull request #152: [MSITE-965] configure system requirements history
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #152:
URL: https://github.com/apache/maven-site-plugin/pull/152#discussion_r1186751198
##########
src/site/site.xml:
##########
@@ -25,7 +25,17 @@ under the License.
<body>
<menu name="Overview">
<item name="Introduction" href="index.html"/>
- <item name="Goals" href="plugin-info.html"/>
+ <item name="Goals" href="plugin-info.html" collapse="true">
+ <item name="site:site" href="site-mojo.html"/>
+ <item name="site:deploy" href="deploy-mojo.html"/>
+ <item name="site:run" href="run-mojo.html"/>
+ <item name="site:stage" href="stage-mojo.html"/>
+ <item name="site:stage-deploy" href="stage-deploy-mojo.html"/>
+ <item name="site:attach-descriptor" href="attach-descriptor-mojo.html"/>
+ <item name="site:jar" href="jar-mojo.html"/>
+ <item name="site:effective-site" href="effective-site-mojo.html"/>
+ <item name="site:help" href="help-mojo.html"/>
+ </item>
Review Comment:
Do we do this for other plugins is well? I am bit confused. It isn't wrong, but inconsistent with others, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] hboutemy commented on a diff in pull request #152: [MSITE-965] configure system requirements history
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #152:
URL: https://github.com/apache/maven-site-plugin/pull/152#discussion_r1186750830
##########
pom.xml:
##########
@@ -507,6 +507,41 @@ under the License.
</dependency>
</dependencies>
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-plugin-report-plugin</artifactId>
+ <configuration>
+ <requirementsHistories>
+ <requirementsHistory>
+ <version>3.11.0</version>
+ <maven>3.0.5</maven>
+ <jdk>1.7</jdk>
+ </requirementsHistory>
+ <requirementsHistory>
+ <version>3.9.0</version>
+ <maven>3.0</maven>
+ <jdk>1.7</jdk>
+ </requirementsHistory>
+ <requirementsHistory>
+ <version>3.7.1</version>
+ <maven>2.2.1</maven>
+ <jdk>1.6</jdk>
+ </requirementsHistory>
+ <requirementsHistory>
+ <version>3.4</version>
+ <maven>2.2.1</maven>
+ <jdk>1.5</jdk>
+ </requirementsHistory>
+ </requirementsHistories>
+ </configuration>
Review Comment:
in fact, I wrote only the last release for each JDK x Maven to keep the list as small as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org