Re: [PR] [SPARK-53128][CORE] Include unmanaged memory bytes in the usage log before execution memory OOM [spark]

["zhztheplayer (via GitHub)" <gi...@apache.org>]

zhztheplayer commented on code in PR #51848:
URL: https://github.com/apache/spark/pull/51848#discussion_r2487032219


##########
core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java:
##########
@@ -339,9 +339,12 @@ public void showMemoryUsage() {
         MDC.of(LogKeys.MEMORY_SIZE, memoryNotAccountedFor),
         MDC.of(LogKeys.TASK_ATTEMPT_ID, taskAttemptId));
       logger.info(
-        "{} bytes of memory are used for execution and {} bytes of memory are used for storage",
+        "{} bytes of memory are used for execution " +
+                "and {} bytes of memory are used for storage " +
+                "and {} bytes of memory are used but unmanaged",

Review Comment:
   Hi dongjoon-hyun, just to clarify, I guess you were suggesting to only change the 3rd sentence here?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org