[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #57: Add measure and topN APIs

[GitBox <gi...@apache.org>]

hanahmily commented on a change in pull request #57:
URL: https://github.com/apache/skywalking-banyandb/pull/57#discussion_r741749826



##########
File path: api/proto/banyandb/database/v1/schema.proto
##########
@@ -116,14 +135,39 @@ message Measure {
     repeated FieldSpec fields = 3;
     // entity indicates which tags will be to generate a series and shard a measure
     Entity entity = 4;
-    // shard_num is the number of shards
-    uint32 shard_num = 5;
-    // ttl indicates time to live, how long the data will be cached
-    Duration ttl = 6;
+    // interval_rules define data points writing interval
+    repeated IntervalRule interval_rules = 5;

Review comment:
       @wu-sheng As we discussed, interval_rules instrument how frequently data points in a series are written? @lujiajing1126 we should add a new tag in the java client to match these rules.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org